Re: [PHP-DEV] Revisiting RFC: Engine Warnings -- Undefined array index

2022-12-12 Thread Thomas Hruska
On 12/12/2022 3:52 PM, Derick Rethans wrote: On 12 December 2022 22:20:27 GMT, Dan Liebner wrote: It has been proposed to make the error level of "Undefined index" configurable so that teams and individual developers can decide for themselves how they want this situation to be handled. Given

Re: [PHP-DEV] Revisiting RFC: Engine Warnings -- Undefined array index

2022-12-12 Thread Rowan Tommins
On 12 December 2022 22:20:27 GMT, Dan Liebner wrote: >Here's my biggest criticism: the change essentially forces this: >$arr['key'] > >to be rewritten as this (or some other intolerably bad alternative): >isset($arr) && isset($arr['key']) && $arr['key'] Fortunately, this is not the case, the

Re: [PHP-DEV] Revisiting RFC: Engine Warnings -- Undefined array index

2022-12-12 Thread Derick Rethans
On 12 December 2022 22:20:27 GMT, Dan Liebner wrote: >It has been proposed to make the error level of "Undefined index" >configurable so that teams and individual developers can decide for >themselves how they want this situation to be handled. Given that: > > - PHP has been treating this as

[PHP-DEV] Revisiting RFC: Engine Warnings -- Undefined array index

2022-12-12 Thread Dan Liebner
First off, hello everyone, I'm Dan. I love PHP and I've been a PHP developer for over 20 years. The recent change to elevating "Undefined index" from E_NOTICE to E_WARNING set forth and passed by https://wiki.php.net/rfc/engine_warnings to me seems antithetical to what PHP has been and what has