Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-09-26 Thread Saki Takamachi
Hi, Marc. There is one additional case to consider. It's backwards compatible. If `strict_types` is not `1`, the code currently out there may be passing `int` to these functions. Therefore, it is better to be aware that such code can have destructive effects, and to consider whether or not to

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-09-26 Thread Marc Bennewitz
Hi Larry, On 26.09.23 20:41, Larry Garfield wrote: On Tue, Sep 26, 2023, at 10:39 AM, Marc Bennewitz wrote: Hi internals I'd like to put a new RFC under discussion: https://wiki.php.net/rfc/integer-rounding Best, Marc I'm honestly kind of confused by this. The basic concept, as I

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-09-26 Thread Larry Garfield
On Tue, Sep 26, 2023, at 10:39 AM, Marc Bennewitz wrote: > Hi internals > > I'd like to put a new RFC under discussion: > https://wiki.php.net/rfc/integer-rounding > > Best, > Marc I'm honestly kind of confused by this. The basic concept, as I understand it, is sound. But the rest of the

[PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-09-26 Thread Marc Bennewitz
Hi internals I'd like to put a new RFC under discussion: https://wiki.php.net/rfc/integer-rounding Best, Marc OpenPGP_0x3936ABF753BC88CE.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature

[PHP-DEV] Add bcround, bcfloor, bcceil to BCMath.

2023-09-26 Thread Saki Takamachi
Hi, internals. I'm currently working on renovating the `round()` function. The current `round()` function rounds a value like 0.285 (0.28499) to 0.29 using pre-round. This is a mistake for FP, so discussions are underway to abolish such pre-round behavior. However, there is definitely a

Re: [PHP-DEV] Security Audit Priorities

2023-09-26 Thread Robert Landers
On Mon, Sep 25, 2023 at 10:49 AM Derick Rethans wrote: > > Hi, > > The Foundation is organising an external audit/security check of the PHP > source code. As part of that, we would like to identify the places in > the PHP source code where checking this will have the most impact. > > Typical