Re: [PHP-DEV] [STRAW POLL] [VOTE] Process resource to object migration

2023-10-24 Thread Jakub Zelenka
Hi, On Tue, Oct 24, 2023, 19:00 Máté Kocsis wrote: > As I have indicated in my last mail ( > https://externals.io/message/121164#121364), I would like to decide the > naming question of the "le_proc_open" resource via a straw poll. Therefore, > I've just opened the vote: https://wiki.php.net/rfc

Re: [PHP-DEV] Change the signature of odbc_connect

2023-10-24 Thread Máté Kocsis
Hi Saki, In my opinion, this is a simple and useful bugfix + nice consistency improvement with negligible backward compatibility break, so I don't think it needs any vote. Regards, Máté

Re: [PHP-DEV] [STRAW POLL] [VOTE] Process resource to object migration

2023-10-24 Thread Máté Kocsis
Hi Tim, > > I assume this should read 2023-**11**-07? This would match the 14 days > for regular votes. > Yes, such a silly typo, thank you for pointing that out. The deadline is indeed in November. Regards, Máté

Re: [PHP-DEV] [STRAW POLL] [VOTE] Process resource to object migration

2023-10-24 Thread Tim Düsterhus
Hi On 10/24/23 20:00, Máté Kocsis wrote: It is a ranked choice poll (following STV) and voting is open until 2023-10-07 18:00:00 UTC. I assume this should read 2023-**11**-07? This would match the 14 days for regular votes. Best regards Tim Düsterhus -- PHP Internals - PHP Runtime Developm

[PHP-DEV] [STRAW POLL] [VOTE] Process resource to object migration

2023-10-24 Thread Máté Kocsis
As I have indicated in my last mail ( https://externals.io/message/121164#121364), I would like to decide the naming question of the "le_proc_open" resource via a straw poll. Therefore, I've just opened the vote: https://wiki.php.net/rfc/process_object_name It is a ranked choice poll (following ST

Re: [PHP-DEV] Custom object equality

2023-10-24 Thread Dik Takken
On 23-10-2023 22:07, Jordan LeDoux wrote: I don't quite follow. The interface would cause the engine to use the result of an `equals()` function on the object if it implements an interface as part of `zend_compare`? Internally there is no `==` function, there is only the equivalent of `<=>`. To i

Re: [PHP-DEV] Custom object equality

2023-10-24 Thread Marc Bennewitz
Hi Jordan, On 23.10.23 22:07, Jordan LeDoux wrote: Implementing the compare handler for an overload requires adding two new entries to ZEND_AST_BINARY_OP because the `>` and `<` comparisons have to be preserved in the AST in order to call the correct object handler. THAT requires updating OpCach