Re: [PHP-DEV] [RFC][Discussion] NotSerializable attribute

2023-12-09 Thread Dennis Snell via internals
> On Dec 9, 2023, at 4:55 PM, Robert Landers wrote: > > On Sat, Dec 9, 2023 at 4:32 PM Dennis Snell via internals > wrote: >> >> Max, I love this idea. >> >> Would it make sense to flip the design though and add `#[Serializable]` with >> a

[PHP-DEV] Re: [RFC][Discussion] NotSerializable attribute

2023-12-09 Thread Dennis Snell via internals
Max, I love this idea. Would it make sense to flip the design though and add `#[Serializable]` with a new `php.ini` setting? I’m thinking that almost every class I use, if not every single class, should not be serialized. If PHP had a flag to say “prevent all classes from serializing” then I

Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-29 Thread Dennis Snell via internals
> Just chiming in here to say that while we don't offer a createFragment() in > this proposal, it's possible to parse fragments by passing the > LIBXML_HTML_NOIMPLIED option. Alternatively, in the future I plan to offer > innerHTML which you could use then in conjunction with >

Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-29 Thread Dennis Snell via internals
> >> >> For both, `XMLDocument::fromEmpty` and `HTMLDocument::createEmpty` there is >> an argument available to define the encoding but none of the other >> `createFrom*` methods have this argument. >> >> As far as I understand, in the these other cases the encoding gets detected >> from the

Re: [PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-21 Thread Dennis Snell via internals
> On Sep 19, 2023, at 12:30 AM, Tim Düsterhus wrote: > > From the perspective of the user of the API, I like the symmetry between all > the named constructors: > > Whenever I want to create a new document, I use one of the fromXyz() methods. > And when I use those, I get exactly what it

[PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-06 Thread Dennis Snell via internals
> On Sep 4, 2023, at 1:15 PM, Niels Dossche wrote: > > On 04/09/2023 21:54, Dennis Snell wrote: >> Thanks for the proposal Niels, >> >> I’ve dealt with my own grief working through issues in DOMDocument and >> wanting it to work but finding it inadequate. >> >>> HTML5 >> >> This would be

[PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-04 Thread Dennis Snell via internals
Thanks for the proposal Niels, I’ve dealt with my own grief working through issues in DOMDocument and wanting it to work but finding it inadequate. > HTML5 This would be a great starting point; I would love it if we took the opportunity to fix named character reference decoding, as PHP has