[PHP-DEV] $_SERVER mostly empty with default variables_order GPCS on FastCGI/CGI

2018-03-05 Thread Matt Ficken
There's a new behavior change with $_SERVER on master branch only, that's broken MediaWiki and should break some other applications. When variables_order=GPCS(default), $_SERVER is only populated with PHP_SELF, REQUEST_TIME_FLOAT and REQUEST_TIME (PATH_TRANSLATED, etc... are missing). Is this an

Re: [PHP-DEV] run-tests.php exit code

2018-03-01 Thread Matt Ficken
If behavior wasn't changed unless ENV var or CLI option was specified, then I think it can go into 7.1 (run-test.php isn't production code part of a build, etc...). Behavior remaining the same of course wouldn't break anybody's existing CI. For those who benefit from this in 7.3, they should

[PHP-DEV] $_SERVER mostly empty with default variables_order GPCS on FastCGI/CGI

2018-02-20 Thread Matt Ficken
There's a new behavior change with $_SERVER on master branch only, that's broken MediaWiki and should break some other applications. When variables_order=GPCS(default), $_SERVER is only populated with PHP_SELF, REQUEST_TIME_FLOAT and REQUEST_TIME (PATH_TRANSLATED, etc... are missing). Is this an

Re: [PHP-DEV] Potential adoption of run-tests.php replacement

2018-01-29 Thread Matt Ficken
This is a reimplementation of run-test.php, not just a wrapper (so its another parser for the PHPT file format). However, its missing support for many PHPT sections (ie its PHPT format support is incomplete). See:

[PHP-DEV] variables_order issue with run-test.php

2017-05-02 Thread Matt Ficken
Hi, I noticed that php.ini-development now sets variables_order="GPCS" instead of "EGPCS". run-test.php uses $_ENV to read environment variables and will set those on all the child processes it creates. However, if variables_order="GPCS", $_ENV will be empty and the environment variables table

Re: [PHP-DEV] run-tests.php improvement for PHP 7.0+

2016-05-09 Thread Matt Ficken
An INI section wouldn't have the extension directory path AND wouldn't have the name of the SO to load. On Windows, its zend_extension=php_opcache.DLL. Typically the same opcache, etc... feature/test should work across os platforms. OpCache tests can just use a SKIPIF section to be skipped unless

Re: [PHP-DEV] Re: Windows OpCache bug fix

2015-10-09 Thread Matt Ficken
/92e568270957a63c8b0d1545d9dc0495a851b5c0 On Wed, Oct 7, 2015 at 4:39 AM, Anatol Belski <anatol@belski.net> wrote: > Hi Matt, > > > -Original Message----- > > From: Matt Ficken [mailto:themattfic...@gmail.com] > > Sent: Wednesday, October 7, 2015 12:18 PM

Re: [PHP-DEV] Re: Windows OpCache bug fix

2015-10-07 Thread Matt Ficken
[mailto:dmi...@zend.com] > > Sent: Tuesday, October 6, 2015 10:01 AM > > To: Anatol Belski <anatol@belski.net> > > Cc: Matt Ficken <themattfic...@gmail.com>; Pierre Joye > > <pierre@gmail.com>; Laruence <larue...@php.net>; PHP Internals > > &l

Re: [PHP-DEV] Re: Windows OpCache bug fix

2015-10-06 Thread Matt Ficken
ssible for 7.0? 7.0.1? On Mon, Oct 5, 2015 at 11:49 AM, Eric Stenson <erics...@microsoft.com> wrote: > >From: Dmitry Stogov [mailto:dmi...@zend.com] > > > >> On Thu, Oct 1, 2015 at 11:54 AM, Matt Ficken <themattfic...@gmail.com> > >> wrote: > >> &

Re: [PHP-DEV] Re: Windows OpCache bug fix

2015-10-01 Thread Matt Ficken
> > > And what wincache does. It is slower but the request is served. > > > WinCache (file cache) if it can't reattach, creates a new shared mem file for just that process: see http://svn.php.net/viewvc/pecl/wincache/trunk/wincache_filemap.c?revision=336846=markup Line 1122. Yes, ideally it would

[PHP-DEV] Re: Windows OpCache bug fix

2015-09-28 Thread Matt Ficken
is really works, we should backport this into php-5.* as well. >> >> Thanks. Dmitry. >> >> On Thu, Sep 24, 2015 at 8:34 AM, Matt Ficken <themattfic...@gmail.com> >> wrote: >> >>> Ok, I have a new PR just to unlock around Sleep(): >>>

[PHP-DEV] Windows OpCache bug fix

2015-09-23 Thread Matt Ficken
I want to increase visibility for my PR 1531, https://github.com/php/php-src/pull/1531, my patch for fixing an intermittent OpCache issue on Windows. Details, etc... are on the PR. Regards -M

[PHP-DEV] Re: Windows OpCache bug fix

2015-09-23 Thread Matt Ficken
> Please, next time, try to make PR diffs as small as possible (without > messing real fix with formatting and rearranging changes). > > Thanks. Dmitry. > > > > On Wed, Sep 23, 2015 at 10:10 AM, Matt Ficken <themattfic...@gmail.com> > wrote: > >> I want to

Re: [PHP-DEV] Q: Writing *.phpt's: How to specify multi-process test?

2015-08-24 Thread Matt Ficken
Clarification: your test depends on being able to run multiple instances of the same test at the same time? run-tests runs one test at a time. It does launch a separate php.exe for each test, but it doesn't use non-blocking popen or pcntl, so it can only run one test at a time. see:

Re: [PHP-DEV] [VOTE] Scalar Type Hints

2015-02-10 Thread Matt Ficken
FYI, the patch doesn't cause a performance regression. I built on and tested with IIS/Windows. Performance remains the same for Wordpress, Symfony and Joomla. Mediawiki actually increased slightly (5%), so performance is increase/decrease is not an issue here, the language and engine are. If

Re: [PHP-DEV] AV on PHP 5.5.18 + Zend Opcache in accel_chdir

2014-11-25 Thread Matt Ficken
Is this crash easily/consistently reproducible? Is it an issue you think is readily fixable? If this is the case, open a new bug. Or is it really rare? Would it likely go unfixed/unvalidated fix for a long time? If this is the case, you should add this to bug #68439, which is a collection of

[PHP-DEV] Native TLS

2014-10-29 Thread Matt Ficken
Anatol has been doing some great work with Thread Local Storage (under the native-tls branch). I have tested it on Windows and its performance and functionality are now the same as master builds (with phpng), though a few extensions included with Windows builds haven't been ported yet.

Re: [PHP-DEV] Concurrency support for run-tests

2014-09-14 Thread Matt Ficken
When building PFTT, the PHP Full Test Tool, one goal was maximizing speed so that we would be more likely to frequently Fully test PHP (Full-coverage of many scenarios), and to do that I built it to run tests concurrently... Concurrent/parallel execution can cause breaks that otherwise work with

Re: [PHP-DEV] Re: [VOTE] Abstract Syntax Tree

2014-08-27 Thread Matt Ficken
I get no new test failures on master after AST merged. Before and after the AST merge, I still get ~200 tests failing on Windows. My test runs turned up a few crashes, which I am reproducing to get BTs to share. I'm not sure if the crashes are AST related. On Tue, Aug 26, 2014 at 2:50 AM,

[PHP-DEV] master/phpng has many Windows specific regressions (PHPT and Joomla)

2014-08-21 Thread Matt Ficken
Master (with PHPNG) builds on Windows (our snapshot build servers were never interrupted BTW), though extensions including PDO, mysql and soap are disabled. Master on Windows now has 201 test failures(all sapi scenarios) while Linux (for me at least) only has about 20 failures, see:

[PHP-DEV] master/phpng has many Windows specific regressions (PHPT and Joomla)

2014-08-21 Thread Matt Ficken
I'm sharing the run-test output for master/phpng on Windows here: http://131.107.220.66/PFTT-Results/Share/20140821/phpng_phpt_windows.txt Also, I'm sharing the Joomla phpunit output here: http://131.107.220.66/PFTT-Results/Share/20140821/phpunit_Joomla-Platform-12.3_Local-FileS.xml

Re: [PHP-DEV] PHP 5.3.29 is available, PHP 5.3 reaching end of life

2014-08-16 Thread Matt Ficken
We've rebuilt 5.3.29 using OpenSSL0.9.8zb and retested and released it. Thanks for the suggestion -M On Fri, Aug 15, 2014 at 1:35 AM, Jan Ehrhardt php...@ehrhardt.nl wrote: Matt Ficken in php.internals (Fri, 15 Aug 2014 00:59:19 -0700): I have tested 5.3.29 on Windows thoroughly as its

Re: [PHP-DEV] PHP 5.3.29 is available, PHP 5.3 reaching end of life

2014-08-15 Thread Matt Ficken
I have tested 5.3.29 on Windows thoroughly as its the last 5.3 release. I find no regressions. All the security and bug fixes didn't break anything from 5.3.28. Windows users at least, that want to stay with 5.3 can now upgrade to 5.3.29. See:

RE: [PHP-DEV] [RFC] Keywords as identifiers

2013-09-18 Thread Matt Ficken
I have run all the PHPT tests from the latest master test-pack against builds with this patch on Windows (all versions 2008+): I get the same failures I get from recent master builds. The patch doesn't break anything on Windows. You can get the PHP builds for Windows with this patch that I used

RE: [PHP-DEV] Current Status of O+ on Windows

2013-03-14 Thread Matt Ficken
: Christopher Jones; Matt Ficken; internals@lists.php.net Subject: Re: [PHP-DEV] Current Status of O+ on Windows Did you experiment with any options? Putting the date of your O+ snapshot would also be handy. Latest from here are used: http://windows.php.net/downloads/pecl

[PHP-DEV] Current Status of O+ on Windows

2013-03-01 Thread Matt Ficken
I am testing O+ on Windows with php 5.3, 5.4, and 5.5. I have uploaded my O+ test results here: http://windows.php.net/downloads/snaps/ostc/pftt/ Crashes have increased with 5.3, 5.4 and 5.5 TS builds with Apache. TS or NTS on CLI seem fine. See

RE: [PHP-DEV] Re: [VOTE] Generators

2012-09-03 Thread Matt Ficken
I have created a single build combining the Generator RFC and the property getter/setter RFC. On Windows, one of the Generator tests fails (tests\generators\clone_with_stack.phpt), but all pass on Linux. There are some regressions due to the branch not included many of the recent fixes for

[PHP-DEV] Re: RFC Property get/set syntax

2012-09-03 Thread Matt Ficken
I have created a single build combining the property get/set RFC and Generator RFC. On Windows, there are some regressions due to the branch not included many of the recent fixes for Windows. Otherwise, on Windows and Linux, there aren't regressions due to the property get/set RFC. The PHP

[PHP-DEV] SVN Account Request: mattficken

2011-08-12 Thread Matt Ficken
QA support for PHP on Windows. working with Pierre Joye. need to commit patches to test cases and report and respond to bugs. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php