Re: [PHP-DEV] New PCRE function

2020-02-21 Thread Nico Oelgart
On Thu, Feb 20, 2020 at 10:12 AM Nikita Popov wrote: > FWIW, it is our established stance that all error messages must be > capitalized. Lower-case first character is only permitted if it is part of > a function name, or similar cases. > Thanks for clearing this up, Nikita. Given that, I think

Re: [PHP-DEV] New PCRE function

2020-02-19 Thread Nico Oelgart
On Wed, Feb 19, 2020 at 4:20 PM David Rodrigues wrote: > Maybe you can set all this messages as lowercase? That way we can use it > more easily. If we need the first letter in capital letters we can use > `ucfirst()`, because the opposite is more complicated (a `strtolower()` > would "break" the

[PHP-DEV] New PCRE function

2020-02-19 Thread Nico Oelgart
Hi Internals, I've submitted a small PR proposing a new PCRE function that returns a human-friendly string representation of the last error. https://github.com/php/php-src/pull/5185 Currently there's only preg_last_error() which returns error codes, which isn't really helpful. Most comments in