Re: [PHP-DEV][RFC][VOTE] Throwable error code's type generalization

2017-01-27 Thread Wes
Closing this. Thanks to the voters! Markus: sorry if i didn't answer, i didn't get the notification. I realize now it wasn't really clear. Patch would've changed Error and Exception constructors only, from int to "mixed". And someone else would have had to write it, because I have no internals kno

Re: [PHP-DEV][RFC][VOTE] Throwable error code's type generalization

2017-01-19 Thread Markus Fischer
Hi, On 06.01.17 18:02, Wes wrote: > Greeting fellow elePHPants and happy new year. > > I've just started the vote for the RFC in subject. You can find it here: > > https://wiki.php.net/rfc/throwable-code-generalization The RFC states: "In practice this is mostly a documentation change ... " Do

Re: [PHP-DEV][RFC][VOTE] Throwable error code's type generalization

2017-01-18 Thread Wes
Voting will end on Jan 27, if you are ok with that. I have been told one week wasn't enough, then also the mailing list problems happened. This should be enough to give everyone the opportunity to vote. Thank you.

Re: [PHP-DEV][RFC][VOTE] Throwable error code's type generalization

2017-01-13 Thread Wes
vote restarted

Re: [PHP-DEV][RFC][VOTE] Throwable error code's type generalization

2017-01-09 Thread Wes
that is actually a good point Marcio. 2017-01-08 21:10 GMT+01:00 Marcio Almada : > Hi Wes, > > 2017-01-08 15:44 GMT-04:00 Wes : > >> Yes, you can. >> http://php.net/manual/en/language.oop5.magic.php#object.tostring :P >> > > It's still not guaranteed that the returned value is "stringifiable" as

Re: [PHP-DEV][RFC][VOTE] Throwable error code's type generalization

2017-01-08 Thread Marcio Almada
Hi Wes, 2017-01-08 15:44 GMT-04:00 Wes : > Yes, you can. > http://php.net/manual/en/language.oop5.magic.php#object.tostring :P > It's still not guaranteed that the returned value is "stringifiable" as it was before. Logging code would now need is_object + method_exist checks and so on. I'm cons

Re: [PHP-DEV][RFC][VOTE] Throwable error code's type generalization

2017-01-08 Thread Wes
Yes, you can. http://php.net/manual/en/language.oop5.magic.php#object.tostring :P

Re: [PHP-DEV][RFC][VOTE] Throwable error code's type generalization

2017-01-08 Thread Niklas Keller
2017-01-08 16:20 GMT+01:00 Wes : > I don't see how objects are less important than strings. Many of us have > enum-ish kind of objects in their code, even if php doesn't support them > natively. We could consider using them as error code if this was allowed. > An object is nothing I can really st

Re: [PHP-DEV][RFC][VOTE] Throwable error code's type generalization

2017-01-08 Thread Wes
I don't see how objects are less important than strings. Many of us have enum-ish kind of objects in their code, even if php doesn't support them natively. We could consider using them as error code if this was allowed.

Re: [PHP-DEV][RFC][VOTE] Throwable error code's type generalization

2017-01-08 Thread Niklas Keller
> > linking to the discussion thread http://externals.io/thread/573 because I > don't have much more to add. > > I think the throwable's code is almost never used regardless, but this > could give users more opportunities to do something useful with it as > Niklas stated in previous thread. > Hi W

Re: [PHP-DEV][RFC][VOTE] Throwable error code's type generalization

2017-01-06 Thread Wes
Deprecating it is also a lot of effort for very little improvement. People would be forced to fix all their constructors calls just to skip the parameter. Personally I would be very annoyed by such a pointless change. Plus those that actually do use the code will be forced eventually to reimplemen

Re: [PHP-DEV][RFC][VOTE] Throwable error code's type generalization

2017-01-06 Thread Marco Pivetta
On 6 Jan 2017 18:27, "Wes" wrote: Hi Marco \o, linking to the discussion thread http://externals.io/thread/573 because I don't have much more to add. I think the throwable's code is almost never used regardless, but this could give users more opportunities to do something useful with it as Nikl

Re: [PHP-DEV][RFC][VOTE] Throwable error code's type generalization

2017-01-06 Thread Wes
Hi Marco \o, linking to the discussion thread http://externals.io/thread/573 because I don't have much more to add. I think the throwable's code is almost never used regardless, but this could give users more opportunities to do something useful with it as Niklas stated in previous thread. Chang

Re: [PHP-DEV][RFC][VOTE] Throwable error code's type generalization

2017-01-06 Thread Marco Pivetta
Hi Wes, On 6 Jan 2017 18:03, "Wes" wrote: Greeting fellow elePHPants and happy new year. I've just started the vote for the RFC in subject. You can find it here: https://wiki.php.net/rfc/throwable-code-generalization Hope it's all fine because this is my first RFC... :P Voting will end 13

[PHP-DEV][RFC][VOTE] Throwable error code's type generalization

2017-01-06 Thread Wes
Greeting fellow elePHPants and happy new year. I've just started the vote for the RFC in subject. You can find it here: https://wiki.php.net/rfc/throwable-code-generalization Hope it's all fine because this is my first RFC... :P Voting will end 13 Jan at 5 PM (UTC). Thank you.