Re: [PHP-DEV] [Patch] tidy node and getParent

2006-03-23 Thread Markus Fischer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, okay, so with whom I've to sleep to get this patch in? :) cheers, - - Markus Markus Fischer wrote: Hi, Antony Dovgal wrote: On 25.01.2006 16:17, Markus Fischer wrote: the patch is in the bug report ( http://bugs.php.net/bug.php?id=34023

Re: [PHP-DEV] [Patch] tidy node and getParent

2006-03-23 Thread John Coggeshall
Committed to HEAD.. I'll let the RM decide where this belongs for PHP 5.1+ before PHP 6 (5.2 probably) Sorry I misspelled your name in the commit ;) John On Thu, 2006-03-23 at 12:16 +0100, Markus Fischer wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, okay, so with whom I've to

Re: [PHP-DEV] [Patch] tidy node and getParent

2006-03-23 Thread Andi Gutmans
Ilia, but don't worry, he's a good looking guy :) hehe At 03:16 AM 3/23/2006, Markus Fischer wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, okay, so with whom I've to sleep to get this patch in? :) cheers, - - Markus Markus Fischer wrote: Hi, Antony Dovgal wrote: On 25.01.2006

Re: [PHP-DEV] [Patch] tidy node and getParent

2006-03-23 Thread Andrey Hristov
Send a bottle of Stolichnaya, this could solve your issue :) Andrey Andi Gutmans wrote: Ilia, but don't worry, he's a good looking guy :) hehe At 03:16 AM 3/23/2006, Markus Fischer wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, okay, so with whom I've to sleep to get this

Re: [PHP-DEV] [Patch] tidy node and getParent

2006-01-25 Thread Markus Fischer
Hi, the patch is in the bug report ( http://bugs.php.net/bug.php?id=34023 ) or do you meant something else? thanks, - Markus Jani Taskinen wrote: If the patch was downloadable somewhere, I bet someone had already committed it. :) --Jani On Wed, 14 Dec 2005, Markus Fischer

Re: [PHP-DEV] [Patch] tidy node and getParent

2006-01-25 Thread Antony Dovgal
On 25.01.2006 16:17, Markus Fischer wrote: Hi, the patch is in the bug report ( http://bugs.php.net/bug.php?id=34023 ) or do you meant something else? Jani meant that it would be better to put this patch as a downloadable file (applying copy-pasted patches causes some problems with

Re: [PHP-DEV] [Patch] tidy node and getParent

2006-01-25 Thread Steph Fox
]; internals@lists.php.net; [EMAIL PROTECTED] Sent: Wednesday, January 25, 2006 3:17 PM Subject: Re: [PHP-DEV] [Patch] tidy node and getParent Hi, the patch is in the bug report ( http://bugs.php.net/bug.php?id=34023 ) or do you meant something else? thanks, - Markus Jani Taskinen wrote

Re: [PHP-DEV] [Patch] tidy node and getParent

2006-01-25 Thread Markus Fischer
Steph Fox wrote: It's been in PAT for ages, unless you made any changes to it Markus? http://www.zend.com/zend/week/pat/pat52.txt No change was done. Wow, I didn't knew that this exists. And now it makes sense because you were mentioned PAT in your email back then which didn't mean anything

Re: [PHP-DEV] [Patch] tidy node and getParent

2006-01-25 Thread Markus Fischer
Hi, Antony Dovgal wrote: On 25.01.2006 16:17, Markus Fischer wrote: the patch is in the bug report ( http://bugs.php.net/bug.php?id=34023 ) or do you meant something else? Jani meant that it would be better to put this patch as a downloadable file (applying copy-pasted patches causes some

Re: [PHP-DEV] [Patch] tidy node and getParent

2006-01-25 Thread John Coggeshall
Sorry this fell off my radar. Is getParent() a new function to tidy? I may have to include some lib checks in my config... John On Wed, 2006-01-25 at 15:22 +0100, Markus Fischer wrote: Hi, Antony Dovgal wrote: On 25.01.2006 16:17, Markus Fischer wrote: the patch is in the bug report (

Re: [PHP-DEV] [Patch] tidy node and getParent

2006-01-25 Thread Markus Fischer
John Coggeshall wrote: Sorry this fell off my radar. Is getParent() a new function to tidy? I may have to include some lib checks in my config... I can't tell, http://tidy.sourceforge.net/docs/api/group__Tree.html lists it and the page was generated in 2002 if that date is correct. Ob my

Re: [PHP-DEV] [Patch] tidy node and getParent

2005-12-14 Thread Markus Fischer
Hi, any chance for http://bugs.php.net/bug.php?id=34023 this time? thanks, - Markus Markus Fischer wrote: Hi, can this be taken into consideration for HEAD now that RC1 is out of the door? thanks, - Markus Andi Gutmans wrote: We're in a feature freeze so please hold it to after 5.1.0 is

Re: [PHP-DEV] [Patch] tidy node and getParent

2005-12-14 Thread Jani Taskinen
If the patch was downloadable somewhere, I bet someone had already committed it. :) --Jani On Wed, 14 Dec 2005, Markus Fischer wrote: Hi, any chance for http://bugs.php.net/bug.php?id=34023 this time? thanks, - Markus Markus Fischer wrote: Hi, can this be taken into

Re: [PHP-DEV] [Patch] tidy node and getParent

2005-12-14 Thread Steph Fox
: [PHP-DEV] [Patch] tidy node and getParent If the patch was downloadable somewhere, I bet someone had already committed it. :) --Jani On Wed, 14 Dec 2005, Markus Fischer wrote: Hi, any chance for http://bugs.php.net/bug.php?id=34023 this time? thanks, - Markus Markus Fischer

[Fwd: [PHP-DEV] [Patch] tidy node and getParent]

2005-09-02 Thread Markus Fischer
Hi, attached the initial email to the list with the patch. I've been running this now since July in a web crawling application which runs every day and had no problems. The application is CLI based and runs for some hours everytime without any sign of memory leaking. However my c knowledge

Re: [PHP-DEV] [Patch] tidy node and getParent

2005-09-02 Thread Wez Furlong
On 9/2/05, Andi Gutmans [EMAIL PROTECTED] wrote: Rasmus, Wez - Any idea about timing for PDO? Are all these bugs crucial to fix for 5.1? Yeah. I don't anticipate each bug as taking a long time to fix, it's just finding the time to do it. Although we have a long weekend this weekend, we have

Re: [PHP-DEV] [Patch] tidy node and getParent

2005-09-01 Thread Andi Gutmans
Hey Markus, As we're waiting for Wez to commit fixes, and this patch is just adding a new function (and not messing with existing functionality), I think it's OK to include... We'll have to roll RC2. Rasmus, Wez - Any idea about timing for PDO? Are all these bugs crucial to fix for 5.1?

Re: [PHP-DEV] [Patch] tidy node and getParent

2005-09-01 Thread John Coggeshall
I seem to have lost the patch, can someone send it to me again and I'll apply it? Andi it's okay I include this in 5.1? John On Thu, 2005-09-01 at 21:52 -0700, Andi Gutmans wrote: Hey Markus, As we're waiting for Wez to commit fixes, and this patch is just adding a new function (and not

Re: [PHP-DEV] [Patch] tidy node and getParent

2005-09-01 Thread Rasmus Lerdorf
Andi Gutmans wrote: Hey Markus, As we're waiting for Wez to commit fixes, and this patch is just adding a new function (and not messing with existing functionality), I think it's OK to include... We'll have to roll RC2. Rasmus, Wez - Any idea about timing for PDO? Are all these bugs

Re: [PHP-DEV] [Patch] tidy node and getParent

2005-08-31 Thread Markus Fischer
Hi, can this be taken into consideration for HEAD now that RC1 is out of the door? thanks, - Markus Andi Gutmans wrote: We're in a feature freeze so please hold it to after 5.1.0 is out the door. You'll be able to commit to head when RC1 is branched off. Thanks, Andi At 01:31 PM

Re: [PHP-DEV] [Patch] tidy node and getParent

2005-08-06 Thread Markus Fischer
I've created a bug report ( http://bugs.php.net/34023 ) so it doesn't get forgotten. - Markus Andi Gutmans wrote: We're in a feature freeze so please hold it to after 5.1.0 is out the door. You'll be able to commit to head when RC1 is branched off. Thanks, Andi At 01:31 PM 7/15/2005 -0400,

[PHP-DEV] [Patch] tidy node and getParent

2005-07-15 Thread Markus Fischer
Hi, attached is a patch to add the getParent() method for the tidyNode against HEAD. It's just a quick patch for me. I don't know if all tidy version support the getTidyParent function and if it's memory leak free so someone should review it first. cheers, - Markus ?

Re: [PHP-DEV] [Patch] tidy node and getParent

2005-07-15 Thread John Coggeshall
I'll take a look at it and commit if it looks good. John On Fri, 2005-07-15 at 12:09 +0200, Markus Fischer wrote: Hi, attached is a patch to add the getParent() method for the tidyNode against HEAD. It's just a quick patch for me. I don't know if all tidy version support the

Re: [PHP-DEV] [Patch] tidy node and getParent

2005-07-15 Thread Andi Gutmans
We're in a feature freeze so please hold it to after 5.1.0 is out the door. You'll be able to commit to head when RC1 is branched off. Thanks, Andi At 01:31 PM 7/15/2005 -0400, John Coggeshall wrote: I'll take a look at it and commit if it looks good. John On Fri, 2005-07-15 at 12:09 +0200,