Hey Theodore,
On Fri, 3 Jul 2020 at 19:52, Theodore Brown wrote:
>
> On Thu, July 2, 2020 at 4:12 PM Benas IML wrote:
>
> > I have opened the voting for the RFC, let's hope everything is going
> > to be smooth :). If you have any other questions, let me know!
> >
> > RFC:
On Thu, July 2, 2020 at 4:12 PM Benas IML wrote:
> I have opened the voting for the RFC, let's hope everything is going
> to be smooth :). If you have any other questions, let me know!
>
> RFC: https://wiki.php.net/rfc/make_ctor_ret_void
Hi Benas,
Thanks for your work on this. I'm in favor of
*just let me know if that is a minor change and I'm okay with updating the
RFC right now.
Best regards,
Benas Seliuginas
On Fri, Jul 3, 2020, 6:20 PM Benas IML wrote:
> Hey Zeev,
>
> For me it doesn't really matter if we enforce `void` rules implicitly in
> PHP 8.1 or PHP 9.0. Just that we do
Hey Zeev,
For me it doesn't really matter if we enforce `void` rules implicitly in
PHP 8.1 or PHP 9.0. Just that we do at some point.
Thus, I'm okay with closing the secondary vote and updating the RFC to
mention only PHP 9.0 (and not PHP 8.1).
Best regards,
Benas Seliuginas
On Fri, Jul 3,
> On 3 Jul 2020, at 13:27, Nikita Popov wrote:
>
> Now, whether this RFC actually makes a sufficient case to disregard policy
> here is a different question, and at the discretion of the voters.
I think this is key here (the first part, not the second).
It doesn’t seem as if the RFC makes any
Hey,
Most of the internals who voted no, as far as I know, did so due to
subjective reasons (i. e. don't want to allow declaring
constructors/destructors as `void`).
I don't think that should affect on what you believe is a change for better
or for worse.
As I mentioned before, it doesn't make
Hi,
I have voted in favour, but enough people I respect have voted against to
make me reconsider.
My understanding is the changes will only cause problems to people who have
returned something from __construct() or __destruct(). As people shouldn't
have done this, IMO it is a smaller BC issue
>
> I think that Larry's and Rowan's replies on the original discussion thread
>> really well explained as to why it makes sense to allow an explicit `void`
>> return type, so I'll just quote them instead ;)
>>
>> Larry:
>> > I see this in the same category as __toString().
>>
>
> I read those
On Fri, Jul 3, 2020 at 11:04 AM Benjamin Eberlei
wrote:
> On Thu, Jul 2, 2020 at 11:12 PM Benas IML
> wrote:
>
> > Hey internals,
> >
> > I have opened the voting for the RFC, let's hope everything is going
> > to be smooth :). If you have any other questions, let me know!
> >
> > RFC:
I think that Larry's and Rowan's replies on the original discussion thread
> really well explained as to why it makes sense to allow an explicit `void`
> return type, so I'll just quote them instead ;)
>
> Larry:
> > I see this in the same category as __toString().
>
I read those yes, but there
Hey Benjamin,
Some internals told me that PHP doesn't follow semver strictly and it
should be okay to enforce `void` rules in PHP 8.1 already.
Naturally, I raised that issue on the mailing list but got no replies. So,
I have put that question as a secondary vote instead.
By the way, is there
Hey Nicolas,
Hey internals,
>>
>> I have opened the voting for the RFC, let's hope everything is going
>> to be smooth :). If you have any other questions, let me know!
>>
>> RFC: https://wiki.php.net/rfc/make_ctor_ret_void
>>
>
> Hi Benas,
>
> I voted "no" to the RFC because to me adding "void"
On Thu, Jul 2, 2020 at 11:12 PM Benas IML wrote:
> Hey internals,
>
> I have opened the voting for the RFC, let's hope everything is going
> to be smooth :). If you have any other questions, let me know!
>
> RFC: https://wiki.php.net/rfc/make_ctor_ret_void
>
> Best regards,
> Benas Seliuginas
>
> Hey internals,
>
> I have opened the voting for the RFC, let's hope everything is going
> to be smooth :). If you have any other questions, let me know!
>
> RFC: https://wiki.php.net/rfc/make_ctor_ret_void
>
Hi Benas,
I voted "no" to the RFC because to me adding "void" to constructor and
Hey internals,
I have opened the voting for the RFC, let's hope everything is going
to be smooth :). If you have any other questions, let me know!
RFC: https://wiki.php.net/rfc/make_ctor_ret_void
Best regards,
Benas Seliuginas
--
PHP Internals - PHP Runtime Development Mailing List
To
15 matches
Mail list logo
