Hello internals,
I updated the RFC to encompass all the feedback:
https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
Let me know if there are any final remarks before we start the vote sometime
next week.
Best regards,
Gina P. Banyard
Hi Nicolas,
Thanks for your input and proactive measures! I've just finished the
analysis
you asked for:
- code: https://gist.github.com/kocsismate/c0d10c820606dfe297f09374aa634df5
- results:
https://gist.github.com/kocsismate/cf3bdfbf35eb10224ee5ecd29b39656b
TLDR: there are 880 packages out of
Hi Gina, Máté
Máté Kocsis and myself would like to propose deprecating implicitly
> nullable parameter types.
>
> The RFC is available on the wiki at the following address:
> https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
>
Thanks for the RFC.
I have the same concerns as Larry but
>
> I just encountered this language inconsistency when trying to remove
> nullable from a constructor-promoted property:
>
> ```
> class MyClass
> {
> public function __construct(
> public ?string $title = null // removing "?" here causes "Fatal
> error: Cannot use null as default
On 22-1-2024 10:50, Gina P. Banyard wrote:
Hello internals,
Máté Kocsis and myself would like to propose deprecating implicitly nullable
parameter types.
The RFC is available on the wiki at the following address:
https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
Best regards,
FWIW I think one year is more than enough of deprecation time for any
change, especially for something so easy as this. It's not like we are
forcing users to upgrade to the newest version as soon as possible. I
still haven't used PHP 8.3, and I most likely will not use it for
another year. In
On Tuesday, 23 January 2024 at 16:37, Larry Garfield
wrote:
> On Tue, Jan 23, 2024, at 2:18 AM, Gina P. Banyard wrote:
>
> > I fundamentally disagree with the logic that we somehow need to "plan"
> > deprecations around how much time we need to provide users to upgrade.
>
>
> I
On Tue, Jan 23, 2024, at 2:18 AM, Gina P. Banyard wrote:
> On Monday, 22 January 2024 at 18:53, Larry Garfield
> wrote:
>> I am in support of this change. My only concern is timeline. This RFC would
>> deprecate it in 8.4, and presumably support would be removed in 9.0. While
>> we haven't
On Tuesday, 23 January 2024 at 02:45, Juliette Reinders Folmer
wrote:
> On 23-1-2024 3:18, Gina P. Banyard wrote:
> > > The RFC notes that PHPStan and friends have an easy flag to make the
> > > change, which is great, but still that's a minority of PHP devs that even
> > > know to use static
On 23-1-2024 3:18, Gina P. Banyard wrote:
The RFC notes that PHPStan and friends have an easy flag to make the change,
which is great, but still that's a minority of PHP devs that even know to use
static analysis.
One does not need to use a static analyser to determine or fix this issue,
On Monday, 22 January 2024 at 18:53, Larry Garfield
wrote:
> I am in support of this change. My only concern is timeline. This RFC would
> deprecate it in 8.4, and presumably support would be removed in 9.0. While we
> haven't discussed a timeline for 9.0, historically the pattern is every 5
On Mon, Jan 22, 2024, at 9:11 PM, Matthew Weier O'Phinney wrote:
> On Mon, Jan 22, 2024 at 12:54 PM Larry Garfield
> wrote:
>
>> I am in support of this change. My only concern is timeline. This RFC
>> would deprecate it in 8.4, and presumably support would be removed in 9.0.
>> While we
On Mon, Jan 22, 2024 at 12:54 PM Larry Garfield
wrote:
> I am in support of this change. My only concern is timeline. This RFC
> would deprecate it in 8.4, and presumably support would be removed in 9.0.
> While we haven't discussed a timeline for 9.0, historically the pattern is
> every 5
On Mon, Jan 22, 2024, at 7:30 PM, Jorg Sowa wrote:
>> The only solution I can think of is to keep the deprecation in place
> until PHP 10, but that's a very long time from now and the RFC says this
> simplifies a decent amount of engine code, so I'm not wild about that idea.
>
> Another solution
> The only solution I can think of is to keep the deprecation in place
until PHP 10, but that's a very long time from now and the RFC says this
simplifies a decent amount of engine code, so I'm not wild about that idea.
Another solution is to have version 8.5. Also given the fact that much of
the
On Mon, Jan 22, 2024, at 9:50 AM, Gina P. Banyard wrote:
> Hello internals,
>
> Máté Kocsis and myself would like to propose deprecating implicitly
> nullable parameter types.
>
> The RFC is available on the wiki at the following address:
>
On 22 January 2024 10:21:12 GMT, tag Knife wrote:
>As you are mistaking `iint $var = null` params as "nullable". Which they
>are not, they are "optional default" parameters.
The feature which is being discussed is that, for the specific case of "=
null", the parameter is made both optional
On Mon, 22 Jan 2024 at 11:51, Gina P. Banyard wrote:
> Hello internals,
>
> Máté Kocsis and myself would like to propose deprecating implicitly
> nullable parameter types.
>
> The RFC is available on the wiki at the following address:
>
On Mon, Jan 22, 2024 at 11:21 AM tag Knife wrote:
> On Mon, 22 Jan 2024 at 09:51, Gina P. Banyard wrote:
>
> > Hello internals,
> >
> > Máté Kocsis and myself would like to propose deprecating implicitly
> > nullable parameter types.
> >
> > The RFC is available on the wiki at the following
I fully support this. I even wanted to propose this RFC myself. Implicitly
nullable parameters are extremely confusing in PHP 8 and they are very easy
to replace.
On Mon, 22 Jan 2024 at 09:51, Gina P. Banyard wrote:
> Hello internals,
>
> Máté Kocsis and myself would like to propose deprecating implicitly
> nullable parameter types.
>
> The RFC is available on the wiki at the following address:
>
On Mon, 22 Jan 2024 at 09:51, Gina P. Banyard wrote:
> Hello internals,
>
> Máté Kocsis and myself would like to propose deprecating implicitly
> nullable parameter types.
>
> The RFC is available on the wiki at the following address:
>
Hello internals,
Máté Kocsis and myself would like to propose deprecating implicitly nullable
parameter types.
The RFC is available on the wiki at the following address:
https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
Best regards,
Gina P. Banyard
--
PHP Internals - PHP Runtime
23 matches
Mail list logo
