Re: [PHP-DEV] [RFC] Escaping RFC for PHP Core - Updates?

2013-09-26 Thread Yasuo Ohgaki
Hi Pierre, On Sat, Sep 7, 2013 at 5:51 PM, Pierre Joye pierre@gmail.com wrote: I like the goal of this proposal. It would however fits much better in ext/filter. Yes, escaping has different purposes than filtering. I have some worries about the implementation. It is not an easy task

Re: [PHP-DEV] [RFC] Escaping RFC for PHP Core - Updates?

2013-09-26 Thread Yasuo Ohgaki
Hi, On Sun, Sep 8, 2013 at 1:36 AM, Nikita Nefedov inefe...@gmail.com wrote: On Sat, 07 Sep 2013 20:08:45 +0400, Michael John Burgess mich...@mjburgess.co.uk wrote: On 07/09/2013 15:41, Levi Morrison wrote: It looks nicer than Escaper::escapeJs(), Escaper::escapeHtml(), etc. Any

Re: [PHP-DEV] [RFC] Escaping RFC for PHP Core - Updates?

2013-09-26 Thread Yasuo Ohgaki
Hi, On Sun, Sep 8, 2013 at 1:43 AM, Levi Morrison morrison.l...@gmail.comwrote: You have a flawed understanding of good functional design. Instead of directly calling the escaping function you would simply ask for a callable and pass in the escaping function. Thus, you could use an

Re: [PHP-DEV] [RFC] Escaping RFC for PHP Core - Updates?

2013-09-07 Thread Yasuo Ohgaki
Hi Leigh, On Sat, Sep 7, 2013 at 2:56 PM, Leigh lei...@gmail.com wrote: Looks like the rfc author was unable to implement it himself at the time of the proposal. The last thing in the discussion thread looks like implement it in PECL first, and it might get bundled later

Re: [PHP-DEV] [RFC] Escaping RFC for PHP Core - Updates?

2013-09-07 Thread Pierre Joye
Hi, On Sep 7, 2013 10:35 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote: Hi Leigh, On Sat, Sep 7, 2013 at 2:56 PM, Leigh lei...@gmail.com wrote: Looks like the rfc author was unable to implement it himself at the time of the proposal. The last thing in the discussion thread looks like

Re: [PHP-DEV] [RFC] Escaping RFC for PHP Core - Updates?

2013-09-07 Thread Levi Morrison
It looks nicer than Escaper::escapeJs(), Escaper::escapeHtml(), etc. Any comments? Please, don't go down this route. You do not want one class to escape all kinds of data; delegate each type of escaping to its own class: JavaScriptEscaper-escape(); PhpEscaper-escape(); HtmlEscaper-escape();

Re: [PHP-DEV] [RFC] Escaping RFC for PHP Core - Updates?

2013-09-07 Thread Michael John Burgess
On 07/09/2013 15:41, Levi Morrison wrote: It looks nicer than Escaper::escapeJs(), Escaper::escapeHtml(), etc. Any comments? Please, don't go down this route. You do not want one class to escape all kinds of data; delegate each type of escaping to its own class: JavaScriptEscaper-escape();

Re: [PHP-DEV] [RFC] Escaping RFC for PHP Core - Updates?

2013-09-07 Thread Nikita Nefedov
On Sat, 07 Sep 2013 20:08:45 +0400, Michael John Burgess mich...@mjburgess.co.uk wrote: On 07/09/2013 15:41, Levi Morrison wrote: It looks nicer than Escaper::escapeJs(), Escaper::escapeHtml(), etc. Any comments? Please, don't go down this route. You do not want one class to escape all

Re: [PHP-DEV] [RFC] Escaping RFC for PHP Core - Updates?

2013-09-07 Thread Levi Morrison
On Sat, Sep 7, 2013 at 10:08 AM, Michael John Burgess mich...@mjburgess.co.uk wrote: On 07/09/2013 15:41, Levi Morrison wrote: It looks nicer than Escaper::escapeJs(), Escaper::escapeHtml(), etc. Any comments? Please, don't go down this route. You do not want one class to escape all

Re: [PHP-DEV] [RFC] Escaping RFC for PHP Core - Updates?

2013-09-07 Thread Levi Morrison
On Sat, Sep 7, 2013 at 10:36 AM, Nikita Nefedov inefe...@gmail.com wrote: On Sat, 07 Sep 2013 20:08:45 +0400, Michael John Burgess mich...@mjburgess.co.uk wrote: On 07/09/2013 15:41, Levi Morrison wrote: It looks nicer than Escaper::escapeJs(), Escaper::escapeHtml(), etc. Any comments?

Re: [PHP-DEV] [RFC] Escaping RFC for PHP Core - Updates?

2013-09-07 Thread Florin Patan
On Sat, Sep 7, 2013 at 6:43 PM, Levi Morrison morrison.l...@gmail.com wrote: On Sat, Sep 7, 2013 at 10:36 AM, Nikita Nefedov inefe...@gmail.com wrote: On Sat, 07 Sep 2013 20:08:45 +0400, Michael John Burgess mich...@mjburgess.co.uk wrote: On 07/09/2013 15:41, Levi Morrison wrote: It

[PHP-DEV] [RFC] Escaping RFC for PHP Core - Updates?

2013-09-06 Thread Yasuo Ohgaki
Hi, Any updates for Escaping RFC for PHP Core? https://wiki.php.net/rfc/escaper I think this is must have item for next PHP. -- Yasuo Ohgaki yohg...@ohgaki.net

Re: [PHP-DEV] [RFC] Escaping RFC for PHP Core - Updates?

2013-09-06 Thread Leigh
On Sep 7, 2013 4:37 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote: Hi, Any updates for Escaping RFC for PHP Core? https://wiki.php.net/rfc/escaper I think this is must have item for next PHP. -- Yasuo Ohgaki yohg...@ohgaki.net Looks like the rfc author was unable to implement it himself