Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-20 Thread Thomas Bley
> Sebastian Bergmann hat am 11.09.2025 08:33 CEST > geschrieben: > > > Am 10.09.2025 um 15:23 schrieb Jakub Zelenka: > > If __sleep is used to serialize private properties (not all but just > > some), then those property names are stored in the mangled format > > ("\x00" . self::class . "\x0

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-20 Thread Jakub Zelenka
Hi, On Wed, Sep 10, 2025 at 3:23 PM Jakub Zelenka wrote: > Hi, > > On Fri, Sep 5, 2025 at 5:55 PM Nicolas Grekas < > nicolas.grekas+...@gmail.com> wrote: > >> Hello internals, >> >> Following the discussion that started at >> https://externals.io/message/128226#128456 I wrote this RFC to formali

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-18 Thread Nicolas Grekas
Hi Tim > Hello internals, > > > > Following the discussion that started at > > https://externals.io/message/128226#128456 I wrote this RFC to > > formalize > > our consensus on the topic. > > > > TL;DR, this is about converting the deprecation of __sleep and __wakeup > > to > > a documentation-ba

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-17 Thread Tim Düsterhus
Hi Am 2025-09-05 17:53, schrieb Nicolas Grekas: Hello internals, Following the discussion that started at https://externals.io/message/128226#128456 I wrote this RFC to formalize our consensus on the topic. TL;DR, this is about converting the deprecation of __sleep and __wakeup to a docume

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-17 Thread Tim Düsterhus
Hi Am 2025-09-10 18:17, schrieb Nicolas Grekas: 2. The examples are biased. As an example, the initial “User” example has a serialization hook that is completely useless. The other examples try to replicate `__sleep()`'s broken behavior exactly, which seems to be a relevant requirement in t

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-13 Thread Jakub Zelenka
Hi, On Mon, Sep 8, 2025 at 4:48 PM Tim Düsterhus wrote: > I disagree with the phrasing that the RFC passed with a “narrow margin”. > I just updated the wording so it now says: > A recent RFC to deprecate the __sleep() and __wakeup() magic methods in favor of __serialize() and __unserialize() p

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-12 Thread Hans Krentel
On Friday 05 September 2025 17:53:20 (+02:00), Nicolas Grekas wrote: > Hello internals, > > Following the discussion that started at > https://externals.io/message/128226#128456 I wrote this RFC to formalize > our consensus on the topic. > > TL;DR, this is about converting the deprecation

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-11 Thread Daniel Scherzer
On Mon, Sep 8, 2025 at 8:21 PM Nicolas Grekas wrote: > Hello internals, > > Following the discussion that started at > https://externals.io/message/128226#128456 I wrote this RFC to formalize > our consensus on the topic. > > TL;DR, this is about converting the deprecation of __sleep and __wakeup

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-11 Thread Tim Düsterhus
Hi On 9/11/25 18:51, Nicolas Grekas wrote: As a corollary to your message, I'm wondering what would be the earliest we could open the vote? Our policy on the topic says: There'd be a minimum of 2 weeks between when an RFC that touches the language is brought up on this list and when it's voted

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-11 Thread Nicolas Grekas
Hi Daniel, Thanks for the update. Le lun. 8 sept. 2025 à 19:25, Daniel Scherzer a écrit : > On Mon, Sep 8, 2025 at 8:21 PM Nicolas Grekas < > nicolas.grekas+...@gmail.com> wrote: > >> Hello internals, >> >> Following the discussion that started at >> https://externals.io/message/128226#128456 I

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-11 Thread Tim Düsterhus
Hi Am 2025-09-10 17:39, schrieb Jakub Zelenka: A recent RFC to deprecate the __sleep() and __wakeup() magic methods in favor of __serialize() and __unserialize() passed (18–9), but only just met the required 2/3 majority. Hope it's better! :) Thank you, the updated phrasing is better indeed

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-10 Thread Sebastian Bergmann
Am 10.09.2025 um 15:23 schrieb Jakub Zelenka: If __sleep is used to serialize private properties (not all but just some), then those property names are stored in the mangled format ("\x00" . self::class . "\x00" prefix). It means to make it compatible in __serialize, the application has to mang

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-10 Thread Jakub Zelenka
Hi, On Fri, Sep 5, 2025 at 5:55 PM Nicolas Grekas wrote: > Hello internals, > > Following the discussion that started at > https://externals.io/message/128226#128456 I wrote this RFC to formalize > our consensus on the topic. > > TL;DR, this is about converting the deprecation of __sleep and __w

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-10 Thread Jakub Zelenka
Hi, On Tue, Sep 9, 2025 at 3:39 PM Tim Düsterhus wrote: > Hi > > Am 2025-09-08 23:14, schrieb Jakub Zelenka: > > I understand your concern about the complexity but this can apply to > > many > > other parts in php-src. As I'm sure you know, this still wouldn't > > likely to > > be considered as

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-09 Thread Tim Düsterhus
Hi Am 2025-09-08 23:14, schrieb Jakub Zelenka: I understand your concern about the complexity but this can apply to many other parts in php-src. As I'm sure you know, this still wouldn't likely to be considered as a security issue. I've intentionally said “security sensitive”. I believe the

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-08 Thread Jakub Zelenka
Hi, On Mon, Sep 8, 2025 at 10:44 PM Tim Düsterhus wrote: > Hi > > On 9/8/25 17:32, Jakub Zelenka wrote: > > I think the point here was that it was close and the RFC itself was > > Again, a 2/3 majority is *not* close. Twice the number of folks were in > favor than against the RFC. > > I meant cl

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-08 Thread Tim Düsterhus
Hi On 9/8/25 17:32, Jakub Zelenka wrote: I think the point here was that it was close and the RFC itself was Again, a 2/3 majority is *not* close. Twice the number of folks were in favor than against the RFC. misleading and omitted some important points that would like change the final res

Re: [PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-08 Thread Jakub Zelenka
Hi, On Mon, Sep 8, 2025 at 4:48 PM Tim Düsterhus wrote: > Hi > > Am 2025-09-05 17:53, schrieb Nicolas Grekas: > > Hello internals, > > > > Following the discussion that started at > > https://externals.io/message/128226#128456 I wrote this RFC to > > formalize > > our consensus on the topic. > >

[PHP-DEV] [RFC] Soft-Deprecate __sleep() and __wakeup()

2025-09-05 Thread Nicolas Grekas
Hello internals, Following the discussion that started at https://externals.io/message/128226#128456 I wrote this RFC to formalize our consensus on the topic. TL;DR, this is about converting the deprecation of __sleep and __wakeup to a documentation-based soft deprecation: https://wiki.php.net/rf