Re: [PHP-DEV] [RFC] Turn gc_collect_cycles into a function pointer

2014-12-11 Thread Pierre Joye
On Fri, Dec 5, 2014 at 2:01 AM, Benjamin Eberlei wrote: > > I agree, this change makes sense this way and is compatible to the way > hooks work right now. This change can be part of the grand refactoring > later on. 7.0 is indeed the best time to do it. > Refactoring the whole extension API is

Re: [PHP-DEV] [RFC] Turn gc_collect_cycles into a function pointer

2014-12-10 Thread Benjamin Eberlei
I updated the RFC to include a paragraph on this. The change should be included as-is and then be part of a potential refactoring, should one happen. On Thu, Dec 4, 2014 at 3:26 PM, Ferenc Kovacs wrote: > > > On Thu, Dec 4, 2014 at 1:17 PM, Julien Pauli wrote: > >> On Thu, Dec 4, 2014 at 12:39

Re: [PHP-DEV] [RFC] Turn gc_collect_cycles into a function pointer

2014-12-04 Thread Chris Wright
On 4 December 2014 at 14:26, Ferenc Kovacs wrote: > On Thu, Dec 4, 2014 at 1:17 PM, Julien Pauli wrote: > > > On Thu, Dec 4, 2014 at 12:39 PM, Ferenc Kovacs wrote: > > > > > > > > > On Thu, Dec 4, 2014 at 11:53 AM, Julien Pauli wrote: > > >> > > >> On Thu, Dec 4, 2014 at 9:30 AM, Benjamin Eber

Re: [PHP-DEV] [RFC] Turn gc_collect_cycles into a function pointer

2014-12-04 Thread Benjamin Eberlei
On Thu, Dec 4, 2014 at 3:26 PM, Ferenc Kovacs wrote: > > > On Thu, Dec 4, 2014 at 1:17 PM, Julien Pauli wrote: > >> On Thu, Dec 4, 2014 at 12:39 PM, Ferenc Kovacs wrote: >> > >> > >> > On Thu, Dec 4, 2014 at 11:53 AM, Julien Pauli wrote: >> >> >> >> On Thu, Dec 4, 2014 at 9:30 AM, Benjamin Ebe

Re: [PHP-DEV] [RFC] Turn gc_collect_cycles into a function pointer

2014-12-04 Thread Ferenc Kovacs
On Thu, Dec 4, 2014 at 1:17 PM, Julien Pauli wrote: > On Thu, Dec 4, 2014 at 12:39 PM, Ferenc Kovacs wrote: > > > > > > On Thu, Dec 4, 2014 at 11:53 AM, Julien Pauli wrote: > >> > >> On Thu, Dec 4, 2014 at 9:30 AM, Benjamin Eberlei > >> wrote: > >> > Good morning, > >> > > >> > This is just a

Re: [PHP-DEV] [RFC] Turn gc_collect_cycles into a function pointer

2014-12-04 Thread Julien Pauli
On Thu, Dec 4, 2014 at 1:17 PM, Julien Pauli wrote: > On Thu, Dec 4, 2014 at 12:39 PM, Ferenc Kovacs wrote: >> >> >> On Thu, Dec 4, 2014 at 11:53 AM, Julien Pauli wrote: >>> >>> On Thu, Dec 4, 2014 at 9:30 AM, Benjamin Eberlei >>> wrote: >>> > Good morning, >>> > >>> > This is just a very small

Re: [PHP-DEV] [RFC] Turn gc_collect_cycles into a function pointer

2014-12-04 Thread Julien Pauli
On Thu, Dec 4, 2014 at 12:39 PM, Ferenc Kovacs wrote: > > > On Thu, Dec 4, 2014 at 11:53 AM, Julien Pauli wrote: >> >> On Thu, Dec 4, 2014 at 9:30 AM, Benjamin Eberlei >> wrote: >> > Good morning, >> > >> > This is just a very small change, I propose this RFC for discussion to >> > turn >> > the

Re: [PHP-DEV] [RFC] Turn gc_collect_cycles into a function pointer

2014-12-04 Thread Ferenc Kovacs
On Thu, Dec 4, 2014 at 11:53 AM, Julien Pauli wrote: > On Thu, Dec 4, 2014 at 9:30 AM, Benjamin Eberlei > wrote: > > Good morning, > > > > This is just a very small change, I propose this RFC for discussion to > turn > > the C function "gc_collect_cycles" into a pointer. > > > > https://wiki.php

Re: [PHP-DEV] [RFC] Turn gc_collect_cycles into a function pointer

2014-12-04 Thread Julien Pauli
On Thu, Dec 4, 2014 at 9:30 AM, Benjamin Eberlei wrote: > Good morning, > > This is just a very small change, I propose this RFC for discussion to turn > the C function "gc_collect_cycles" into a pointer. > > https://wiki.php.net/rfc/gc_fn_pointer > > Composer's garbage collection optimization sho

Re: [PHP-DEV] [RFC] Turn gc_collect_cycles into a function pointer

2014-12-04 Thread Xinchen Hui
Hey: On Thu, Dec 4, 2014 at 4:30 PM, Benjamin Eberlei wrote: > Good morning, > > This is just a very small change, I propose this RFC for discussion to turn > the C function "gc_collect_cycles" into a pointer. yeah, this idea is better than add hardly getimeofday into gc thanks > > https://wiki.

[PHP-DEV] [RFC] Turn gc_collect_cycles into a function pointer

2014-12-04 Thread Benjamin Eberlei
Good morning, This is just a very small change, I propose this RFC for discussion to turn the C function "gc_collect_cycles" into a pointer. https://wiki.php.net/rfc/gc_fn_pointer Composer's garbage collection optimization showed that PHP Profilers fail to capture the dynamics of GC and we need