Re: [PHP-DEV] 5.4 beta & tests

2011-09-02 Thread Daniel Convissor
Hi Again: On Thu, Sep 01, 2011 at 03:56:57PM -0400, Daniel Convissor wrote: > > http://www.analysisandsolutions.com/php/mysqli.test.failures.tbz > > I didn't modify the tests because they're working for other people. > > Built 5.4 from svn checkout this afternoon using "--with-mysqli=mysqlnd." >

Re: [PHP-DEV] 5.4 beta & tests

2011-09-01 Thread Daniel Convissor
Hi: On Tue, Aug 30, 2011 at 10:55:48PM -0700, Rasmus Lerdorf wrote: > > http://codepad.org/ZV8imUuc I see Rasmus is only getting one mysqli failure. I'm getting several. The diff, out and exp files can be found here: http://www.analysisandsolutions.com/php/mysqli.test.failures.tbz I didn't mod

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Johannes Schlüter
On Wed, 2011-08-31 at 10:42 -0400, Matthew Weier O'Phinney wrote: > On 2011-08-31, Rasmus Lerdorf wrote: > > I am down to 34 test failures compiling against mysqlnd instead of libmysql > > > > http://codepad.org/ZV8imUuc > > > > I did have to set MYSQL_TEST_SOCKET=/var/run/mysqld/mysqld.sock in my

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Matthew Weier O'Phinney
On 2011-08-31, Rasmus Lerdorf wrote: > I am down to 34 test failures compiling against mysqlnd instead of libmysql > > http://codepad.org/ZV8imUuc > > I did have to set MYSQL_TEST_SOCKET=/var/run/mysqld/mysqld.sock in my > environment though. It was defaulting to /tmp/mysql.sock I've noticed this

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Tjerk Meesters
On Aug 31, 2011 12:14 PM, "Rasmus Lerdorf" wrote: > > On 08/30/2011 08:39 PM, Stas Malyshev wrote: > > Hi! > > > > I've checked the unit tests on my Mac and I see 48 failures so far. I've > > put them here: > > https://wiki.php.net/todo/tests54?&#tested_2011-08-30_on_mac_os_x > > > > Most of them

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Christian Stocker
On 31.08.11 13:32, Ilia Alshanetsky wrote: > Revert sounds find to me, the change was indeed to fix the test. Ok. Committed. JFTR, I also fixed the tests in xsl and libxml. They should pass now (at least on my machine they do :)) chregu > > On Wed, Aug 31, 2011 at 6:58 AM, Christian Stocker

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Rob Richards
On Aug 31, 2011, at 5:39 AM, Christian Stocker wrote: > > > On 31.08.11 09:47, Stas Malyshev wrote: >> Hi! >> >> For simplexml test (ext/simplexml/tests/bug48601.phpt), it looks like >> Ilia reverted the fix for bug #48601 with this: >> >> http://svn.php.net/viewvc/php/php-src/branches/PHP

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Ilia Alshanetsky
Revert sounds find to me, the change was indeed to fix the test. On Wed, Aug 31, 2011 at 6:58 AM, Christian Stocker wrote: > > > On 31.08.11 12:25, Laruence wrote: >> Hi: >>     I think you should not commit untill ask ilia for the reason of >> previous change, > > sure, but my guess is he just f

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Christian Stocker
On 31.08.11 12:25, Laruence wrote: > Hi: > I think you should not commit untill ask ilia for the reason of > previous change, sure, but my guess is he just fixed the code to pass the test, but IMHO the test was wrong (and my patches fixes that). ilia? chregu > > thanks > > 2011/8/31 Chris

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Laruence
Hi: I think you should not commit untill ask ilia for the reason of previous change, thanks 2011/8/31 Christian Stocker : > Hi > > Here's my proposed patch > https://gist.github.com/1183212 > > If noone objects, I'll commit it soon > > chregu > > On 31.08.11 11:39, Christian Stocker wrote: >>

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Christian Stocker
Hi Here's my proposed patch https://gist.github.com/1183212 If noone objects, I'll commit it soon chregu On 31.08.11 11:39, Christian Stocker wrote: > > > On 31.08.11 09:47, Stas Malyshev wrote: >> Hi! >> >> For simplexml test (ext/simplexml/tests/bug48601.phpt), it looks like >> Ilia reverte

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Christian Stocker
On 31.08.11 09:47, Stas Malyshev wrote: > Hi! > > For simplexml test (ext/simplexml/tests/bug48601.phpt), it looks like > Ilia reverted the fix for bug #48601 with this: > > http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/ext/simplexml/simplexml.c?r1=311870&r2=311874 > > > I'm not sure

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Stas Malyshev
Hi! For simplexml test (ext/simplexml/tests/bug48601.phpt), it looks like Ilia reverted the fix for bug #48601 with this: http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/ext/simplexml/simplexml.c?r1=311870&r2=311874 I'm not sure what simplexml is supposed to return in each case, the t

Re: [PHP-DEV] 5.4 beta & tests

2011-08-31 Thread Laruence
Hi: it's odd that parse_ini_*.phpt failed in my built environ, but seems didn't fail in your list. so maybe my changes is not appropriate? thanks 2011/8/31 Stas Malyshev : > Hi! > > I've checked the unit tests on my Mac and I see 48 failures so far. I've put > them here: https://wiki.php

Re: [PHP-DEV] 5.4 beta & tests

2011-08-30 Thread Lonny Kapelushnik
> > Test strtolower() function [ext/standard/tests/strings/strtolower.phpt] > Test strtoupper() function [ext/standard/tests/strings/strtoupper1.phpt] > > I believe these fail on OSX because we test for undefined ASCII behavior. We call strtolower/strtoupper for all 256 ASCII characters, but ASCII

Re: [PHP-DEV] 5.4 beta & tests

2011-08-30 Thread Stas Malyshev
Hi! On 8/30/11 10:55 PM, Rasmus Lerdorf wrote: I am down to 34 test failures compiling against mysqlnd instead of libmysql http://codepad.org/ZV8imUuc I did have to set MYSQL_TEST_SOCKET=/var/run/mysqld/mysqld.sock in my environment though. It was defaulting to /tmp/mysql.sock I'm looking in

Re: [PHP-DEV] 5.4 beta & tests

2011-08-30 Thread Rasmus Lerdorf
I am down to 34 test failures compiling against mysqlnd instead of libmysql http://codepad.org/ZV8imUuc I did have to set MYSQL_TEST_SOCKET=/var/run/mysqld/mysqld.sock in my environment though. It was defaulting to /tmp/mysql.sock -Rasmus -- PHP Internals - PHP Runtime Development Mailing List

Re: [PHP-DEV] 5.4 beta & tests

2011-08-30 Thread Stas Malyshev
Hi! On 8/30/11 10:23 PM, Rasmus Lerdorf wrote: Which means, since we can't touch the environment in php_date.c code, we have to set TZ env variable for the test to pass, and strftime for Mac is dependent on TZ env and we can't do a thing about it as it seems. Right, so this is an XFAIL test on

Re: [PHP-DEV] 5.4 beta & tests

2011-08-30 Thread Rasmus Lerdorf
On 08/30/2011 10:08 PM, Stas Malyshev wrote: > Hi! > > On 8/30/11 9:53 PM, Stas Malyshev wrote: >> strftime() on Mac seems to ignore timezone arguments in struct tm for >> some reason and uses environment TZ instead. Not sure how to address >> that. > > Looking into Mac strftime sources, it says

Re: [PHP-DEV] 5.4 beta & tests

2011-08-30 Thread Stas Malyshev
Hi! On 8/30/11 9:53 PM, Stas Malyshev wrote: strftime() on Mac seems to ignore timezone arguments in struct tm for some reason and uses environment TZ instead. Not sure how to address that. Looking into Mac strftime sources, it says this: ** C99 says that the UTC offse

Re: [PHP-DEV] 5.4 beta & tests

2011-08-30 Thread Stas Malyshev
Hi! On 8/30/11 9:13 PM, Rasmus Lerdorf wrote: Why is your tests/func/005a.phpt failing? That seems to pass consistently for most people. tests/lang/045.phpt is the one that fails for everyone because we don't re-apply the timeout for a registered shutdown function. We should either fix that or

Re: [PHP-DEV] 5.4 beta & tests

2011-08-30 Thread Rasmus Lerdorf
On 08/30/2011 08:39 PM, Stas Malyshev wrote: > Hi! > > I've checked the unit tests on my Mac and I see 48 failures so far. I've > put them here: > https://wiki.php.net/todo/tests54?&#tested_2011-08-30_on_mac_os_x > > Most of them are mysql, but others too. > So, is there anybody working or willin

Re: [PHP-DEV] 5.4 beta & tests

2011-08-30 Thread Stas Malyshev
Hi! On 8/30/11 8:57 PM, Laruence wrote: Hi: I run make test yesterday, and seems the result is quite different anyway, I will check it agian, PS, it's better if there is the test.diff and the config.log (like link against libmysql or mysqlnd ) I'm linking against libmysql, ve

Re: [PHP-DEV] 5.4 beta & tests

2011-08-30 Thread Laruence
Stas: sorry for missing the info about diff , anyway, the http://qa.php.net/reports/ seems down: "An error occured when reading a DB file." thanks 2011/8/31 Laruence : > Hi: >   I run make test yesterday,  and seems the result is quite  different > >   anyway, I will check it agian, > >   P

Re: [PHP-DEV] 5.4 beta & tests

2011-08-30 Thread Laruence
Hi: I run make test yesterday, and seems the result is quite different anyway, I will check it agian, PS, it's better if there is the test.diff and the config.log (like link against libmysql or mysqlnd ) thanks 2011/8/31 Stas Malyshev : > Hi! > > I've checked the unit tests on my M

[PHP-DEV] 5.4 beta & tests

2011-08-30 Thread Stas Malyshev
Hi! I've checked the unit tests on my Mac and I see 48 failures so far. I've put them here: https://wiki.php.net/todo/tests54?&#tested_2011-08-30_on_mac_os_x Most of them are mysql, but others too. So, is there anybody working or willing to work to fix them all for beta? Should we postpone t