Re: [PHP-DEV] 64-bit performance improvement by reducing zend_op size.

2014-12-11 Thread Patrick ALLAERT
Hi, 2014-12-10 16:27 GMT+01:00 Dmitry Stogov dmi...@zend.com: Hi, Please, review the following patch https://gist.github.com/dstogov/fba2cc621ef121826efe Looks good, but Isn't ZEND_EX_USE_RUN_TIME_CACHE always defined to 1 with your patch? Regards, Patrick -- PHP Internals - PHP Runtime

Re: [PHP-DEV] 64-bit performance improvement by reducing zend_op size.

2014-12-11 Thread Dmitry Stogov
Right. Actually ZEND_EX_USE_RUN_TIME_CACHE and ZEND_EX_USE_LITERALS just control if corresponding fields of executed op_array should be cached in current call frame (zend_execute_data). VM will have to execute additional read/write on enter to each function, but then safe 1 read on each access to

Re: [PHP-DEV] 64-bit performance improvement by reducing zend_op size.

2014-12-11 Thread Anatol Belski
Hi, On Wed, December 10, 2014 16:27, Dmitry Stogov wrote: Hi, Please, review the following patch https://gist.github.com/dstogov/fba2cc621ef121826efe It's huge, but actually, only changes in zend_compile.h are matter. The rest is obvious renaming. the main idea - the smaller the

[PHP-DEV] 64-bit performance improvement by reducing zend_op size.

2014-12-10 Thread Dmitry Stogov
Hi, Please, review the following patch https://gist.github.com/dstogov/fba2cc621ef121826efe It's huge, but actually, only changes in zend_compile.h are matter. The rest is obvious renaming. the main idea - the smaller the zend_op structure, the lees memory traffic is required to load VM

Re: [PHP-DEV] 64-bit performance improvement by reducing zend_op size.

2014-12-10 Thread guilhermebla...@gmail.com
Seems good for me. =) On Wed, Dec 10, 2014 at 10:27 AM, Dmitry Stogov dmi...@zend.com wrote: Hi, Please, review the following patch https://gist.github.com/dstogov/fba2cc621ef121826efe It's huge, but actually, only changes in zend_compile.h are matter. The rest is obvious renaming. the