Re: [PHP-DEV] Call for participation: Annotating internal function argument and return types

2019-08-12 Thread Dik Takken
Hi, I'd be happy to donate some time to this effort as well. If you just assign me a file or directory (not too much at once please) I can create a PR that covers that part of the code base. Would that work for you? Regards, Dik On 10-08-19 12:56, Nikita Popov wrote: > Hi, > > Lack of type

Re: [PHP-DEV] Call for participation: Annotating internal function argument and return types

2019-08-10 Thread Nikita Popov
On Sat, Aug 10, 2019 at 2:00 PM Stephen Reay wrote: > > > On 10 Aug 2019, at 17:56, Nikita Popov wrote: > > > > Hi, > > > > Lack of type information for internal functions in Reflection is a > > long-standing issue. In PHP 8 we finally have all the necessary technical > > groundwork done to

Re: [PHP-DEV] Call for participation: Annotating internal function argument and return types

2019-08-10 Thread Benjamin Morel
Hi, Sorry if I’m missing something, but can’t the process be automated? i.e. parse the C source files with a script to generate the stubs? If correctly done, this could be much less error-prone than manual handling. Benjamin > Le 10 août 2019 à 14:00, Stephen Reay a écrit : > -- PHP

Re: [PHP-DEV] Call for participation: Annotating internal function argument and return types

2019-08-10 Thread Stephen Reay
> On 10 Aug 2019, at 17:56, Nikita Popov wrote: > > Hi, > > Lack of type information for internal functions in Reflection is a > long-standing issue. In PHP 8 we finally have all the necessary technical > groundwork done to support argument and return type annotations on internal > functions

Re: [PHP-DEV] Call for participation: Annotating internal function argument and return types

2019-08-10 Thread Craig Duncan
I'm happy to help. Am I correct in thinking that the best way to locate outstanding ones is to to search for any instances of *ZEND_BEGIN_ARG_INFO* or *ZEND_BEGIN_ARG_INFO_EX* in *.c files? As once they've been converted they'll only appear in stub and header files?

[PHP-DEV] Call for participation: Annotating internal function argument and return types

2019-08-10 Thread Nikita Popov
Hi, Lack of type information for internal functions in Reflection is a long-standing issue. In PHP 8 we finally have all the necessary technical groundwork done to support argument and return type annotations on internal functions at scale. The only thing left is to actually add those type