Re: [PHP-DEV] Feedback requested on using #defines to improve the performance of the TSRMG macro

2009-11-05 Thread Arvind Srinivasan
Does the GLOBALS_ID_BASE idea work?  In ts_allocate_reserved_id(GLOBALS_ID_BASE+1...) each extension would anyway need to reserve an increment to avoid clashes.  Also, why is I didn't really try using this. When I added it, I thought it might be useful for modules that live outside the PHP

Re: [PHP-DEV] Feedback requested on using #defines to improve the performance of the TSRMG macro

2009-11-05 Thread mm w
so should be a UUID rather than a user defined int you cannot avoid collision with your system, it's a dangerous way to go. Best, On Thu, Nov 5, 2009 at 11:20 AM, Arvind Srinivasan yoa...@gmail.com wrote: Does the GLOBALS_ID_BASE idea work?  In ts_allocate_reserved_id(GLOBALS_ID_BASE+1...)

Re: [PHP-DEV] Feedback requested on using #defines to improve the performance of the TSRMG macro

2009-11-05 Thread Christopher Jones
Hi Arvind, Does the GLOBALS_ID_BASE idea work? In ts_allocate_reserved_id(GLOBALS_ID_BASE+1...) each extension would anyway need to reserve an increment to avoid clashes. Also, why is GLOBALS_ID_BASE 30 when the largest reserved value is 18? Maybe I'm missing something. Would there be

Re: [PHP-DEV] Feedback requested on using #defines to improve the performance of the TSRMG macro

2009-11-05 Thread Christopher Jones
Arvind Srinivasan wrote: Does the GLOBALS_ID_BASE idea work? In ts_allocate_reserved_id(GLOBALS_ID_BASE+1...) each extension would anyway need to reserve an increment to avoid clashes. Also, why is I didn't really try using this. When I added it, I thought it might be useful for modules

Re: [PHP-DEV] Feedback requested on using #defines to improve the performance of the TSRMG macro

2009-11-05 Thread Stanislav Malyshev
Hi! When compiled for multi-threaded (#ifdef ZTS ) operation, the various subsystems in PHP use dynamically allocated (ts_allocate_id) identifiers to index into the thread-local storage for each subsystem. These dynamically allocated ids are used by macros such as CG, EG, PG, AG. I think it

Re: [PHP-DEV] Feedback requested on using #defines to improve the performance of the TSRMG macro

2009-11-05 Thread Basant Kukreja
+1 Regards, Basant. On Thu, Nov 05, 2009 at 05:22:34PM +0530, Arvind Srinivasan wrote: When compiled for multi-threaded (#ifdef ZTS ) operation, the various subsystems in PHP use dynamically allocated (ts_allocate_id) identifiers to index into the thread-local storage for each subsystem.