I'll commit the patch to PHP_5_0 branch after
5.0.4 is released. This is not a showstopper.
--Jani
On Mon, 28 Mar 2005, Kamesh Jayachandran wrote:
Hi Jani,
Thanks for commiting the patch.
But I feel you can do the same on PHP-5.0.4-dev tree also.
With regards
Kamesh Jayachandran
On
Hi Jani,
Thanks for commiting the patch.
But I feel you can do the same on PHP-5.0.4-dev tree also.
With regards
Kamesh Jayachandran
On Sat, 26 Mar 2005 04:45:58 +0200 (EET), Jani Taskinen
[EMAIL PROTECTED] said:
On Sun, 20 Mar 2005, Kamesh Jayachandran wrote:
Hi Andi,
I could not see
On Sun, 20 Mar 2005, Kamesh Jayachandran wrote:
Hi Andi,
I could not see this change in CVS both in 5_0_4-dev tree and HEAD.
Can someone apply my patch?
Done.
--Jani
With regards
Kamesh Jayachandran
On Fri, 18 Mar 2005 13:56:25 -0800, Andi Gutmans [EMAIL PROTECTED] said:
Yeah it might make
Hi Andi,
I could not see this change in CVS both in 5_0_4-dev tree and HEAD.
Can someone apply my patch?
With regards
Kamesh Jayachandran
On Fri, 18 Mar 2005 13:56:25 -0800, Andi Gutmans [EMAIL PROTECTED] said:
Yeah it might make sense to move that to a function. But for some reason
I
Hi,
In case of interactive mode the
for ZEND_JMP
op1.u.jmp_addr is not evaluated, it still has the relative diff from the
current opcode.
for ZEND_JMP, ZEND_JMPNZ, ZEND_JMPZ_EX, ZEND_JMPNZ_EX
op2.u.jmp_addr is not evaluated, it still has the relative diff from the
current opcode.
This normally
On Fri, 18 Mar 2005, Kamesh Jayachandran wrote:
Hi,
In case of interactive mode the
for ZEND_JMP
op1.u.jmp_addr is not evaluated, it still has the relative diff from the
current opcode.
for ZEND_JMP, ZEND_JMPNZ, ZEND_JMPZ_EX, ZEND_JMPNZ_EX
op2.u.jmp_addr is not evaluated, it still has
Hello Kamesh,
Friday, March 18, 2005, 12:46:44 PM, you wrote:
KJ This normally happens from pass_two.
KJ I am attaching the patch which does this jmp_addr evaluation. This patch
KJ is against php-5.0.4-dev-RC[2].
your code will duplicate some lines pass_two(), won't it?
or
Hi Val,
Yes I got this fix from pass_two only. It duplicates pass_two especially
the while loop.
With regards
Kamesh Jayachandran
On Fri, 18 Mar 2005 13:05:46 +0200, val khokhlov [EMAIL PROTECTED]
said:
Hello Kamesh,
Friday, March 18, 2005, 12:46:44 PM, you wrote:
KJ This normally happens
Hello Kamesh,
Friday, March 18, 2005, 1:15:53 PM, you wrote:
KJ Yes I got this fix from pass_two only. It duplicates pass_two especially
KJ the while loop.
you see, i also use this part of pass_two() code in my ext. maybe,
it'd be a good idea to find one place for this jump addr
Yeah it might make sense to move that to a function. But for some reason I
already see that zend_execute_API.c contains this code in HEAD. Did someone
apply and I missed the commit msg?
Kamesh, can you please verify if it exists in your source tree?
Good catch btw.
Andi
At 01:46 PM 3/18/2005
10 matches
Mail list logo
