Re: [PHP-DEV] PHP 5.1 Release Candidate 1

2005-07-31 Thread Nuno Lopes
Today I was trying to reduce the number of tests that fail on my solaris boxes. (because I don't remember to see PHP pass all the tests) I needed to patch a couple of tests that didn't work well on that plataform. Detailed explanation (I hope): ext/date/tests/bug32555.phpt strftime is system/lo

Re: [PHP-DEV] PHP 5.1 Release Candidate 1

2005-07-28 Thread Marcus Boerger
Hello Andi, na you convinced me. I only wanted to make fun out of the situation and we really all forgot about the issue, didn't we? regards marcus Thursday, July 28, 2005, 11:45:52 PM, you wrote: > We'll save the discussion for after the Unicode merge but I actually came > up with some very

Re: [PHP-DEV] PHP 5.1 Release Candidate 1

2005-07-28 Thread Andi Gutmans
At 11:59 PM 7/28/2005 +0200, Marcus Boerger wrote: Hello Andi, na you convinced me. I only wanted to make fun out of the situation and we really all forgot about the issue, didn't we? :) Andi regards marcus Thursday, July 28, 2005, 11:45:52 PM, you wrote: > We'll save the discussion f

Re: [PHP-DEV] PHP 5.1 Release Candidate 1

2005-07-28 Thread Andi Gutmans
We'll save the discussion for after the Unicode merge but I actually came up with some very good reasons why it's dangerous. Marcus just likes to ignore them :) At 10:51 PM 7/27/2005 +0200, Marcus Boerger wrote: Hello Adam, "we accepted that availability of enough excuses to delay it furthe

Re: [PHP-DEV] PHP 5.1 Release Candidate 1

2005-07-28 Thread John Coggeshall
Honestly it's only a patch to the build system to add basically --enable-gcov to the configure (much like --enable-debug). Basically it just checks for the proper libraries and utilities during configure as it should and if everything is okay builds PHP with the proper compile- time flags and libr

Re: [PHP-DEV] PHP 5.1 Release Candidate 1

2005-07-28 Thread Andi Gutmans
Okay cool. In any case, when it's convenient sending it over to internals@ (maybe after OSCON) makes sense as many here weren't at ApacheCon EU. Andi At 08:37 PM 7/28/2005 +0200, Marcus Boerger wrote: Hello Andi, during apacheCon EU it only needed a few more tweaks which should be done by n

Re: [PHP-DEV] PHP 5.1 Release Candidate 1

2005-07-28 Thread Marcus Boerger
Hello Andi, during apacheCon EU it only needed a few more tweaks which should be done by now (john?). And i can only say it looks really great! But anyway it's sense is to produce more tests where we don't have any yet. And since writing tests requires a lot of work most people hate i guess we c

Re: [PHP-DEV] PHP 5.1 Release Candidate 1

2005-07-28 Thread Andi Gutmans
Is this an extension or changes to the core? Do you already have a patch? In any case, this would have to wait until earliest after the branch and go to HEAD. But I suggest to first make a proposal and show what you're planning on doing here on internals@ Andi At 03:02 PM 7/27/2005 -0400, Joh

Re: [PHP-DEV] PHP 5.1 Release Candidate 1

2005-07-27 Thread Marcus Boerger
Hello Adam, "we accepted that availability of enough excuses to delay it further in the hope we never implement it :-)" To be honest, we all - obviously including you - forgot about the issue completley and only realized it during beta process. And for a thing that need so heavy testing sin

Re: [PHP-DEV] PHP 5.1 Release Candidate 1

2005-07-27 Thread Adam Maccabee Trachtenberg
I can't remember the status of __toString(), but I thought we agreed improving it was a 5.1 feature, pending an investigation to make sure we were able to handle this gracefully in the engine. I don't remember seeing any updates to this code, so I wanted to see if I missed it, or if we decided to

Re: [PHP-DEV] PHP 5.1 Release Candidate 1

2005-07-27 Thread John Coggeshall
I'd also like to get this in to PHP 5.1+ after we branch before Unicode: http://blog.coggeshall.org/archives/204_Code_Coverage_Support_for_PHP_5.html John -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] PHP 5.1 Release Candidate 1

2005-07-27 Thread Jani Taskinen
These should be definately fixed: http://bugs.php.net/bug.php?id=33772&edit=1 (destruct thing) http://bugs.php.net/bug.php?id=33723&edit=1 (apache + php_admin_value issue) These would be nice to get fixed: http://bugs.php.net/bug.php?id=31177&edit=1 (memory leak) http:/

Re: [PHP-DEV] PHP 5.1 Release Candidate 1

2005-07-26 Thread Andrei Zmievski
We probably shouldn't merge anything in until after OSCON. When is Dmitriy back? -Andrei On Jul 26, 2005, at 5:50 PM, Andi Gutmans wrote: Hi all, As planned (a tiny bit delayed), I'd like to RC1 PHP 5.1 within the next few days. I suggest to aim for Tuesday in a week. If there are any cr

[PHP-DEV] PHP 5.1 Release Candidate 1

2005-07-26 Thread Andi Gutmans
Hi all, As planned (a tiny bit delayed), I'd like to RC1 PHP 5.1 within the next few days. I suggest to aim for Tuesday in a week. If there are any critical issues which need addressing please email me. As previously mentioned, I'd like to branch of PHP_5_1 after RC1 in order to allow for the