Re: [PHP-DEV] PROPOSAL: temp stream for post_data

2013-09-16 Thread Gustavo Lopes
On Mon, 16 Sep 2013 09:01:02 +0200, Michael Wallner wrote: On 10 September 2013 13:29, Michael Wallner wrote: On 28 August 2013 08:14, Michael Wallner wrote: On 27 August 2013 23:17, Gustavo Lopes wrote: I think it's generally a good idea, but I have some concerns: ... Fixed. The input

Re: [PHP-DEV] PROPOSAL: temp stream for post_data

2013-09-16 Thread Michael Wallner
Hi all! On 10 September 2013 13:29, Michael Wallner wrote: > On 28 August 2013 08:14, Michael Wallner wrote: >> On 27 August 2013 23:17, Gustavo Lopes wrote: > >>> I think it's generally a good idea, but I have some concerns: > ... > Fixed. The input stream is reusable *and* may be used JIT. >

Re: [PHP-DEV] PROPOSAL: temp stream for post_data

2013-09-10 Thread Michael Wallner
On 28 August 2013 08:14, Michael Wallner wrote: > Hi Gustavo, thank you for your review! > > On 27 August 2013 23:17, Gustavo Lopes wrote: >> I think it's generally a good idea, but I have some concerns: >> >> * The whole point of PG(enable_post_data_reading) is to be able to read the >> input o

Re: [PHP-DEV] PROPOSAL: temp stream for post_data

2013-08-27 Thread Michael Wallner
Hi Gustavo, thank you for your review! On 27 August 2013 23:17, Gustavo Lopes wrote: > On 27-08-2013 14:08, Michael Wallner wrote: >> >> Hi, >> >> I prepared a patch to replace sapi_globals' request_info post_data and >> raw_post_data with a temp stream and remove support for >> HTTP_RAW_POST_DAT

Re: [PHP-DEV] PROPOSAL: temp stream for post_data

2013-08-27 Thread Gustavo Lopes
On 27-08-2013 14:08, Michael Wallner wrote: Hi, I prepared a patch to replace sapi_globals' request_info post_data and raw_post_data with a temp stream and remove support for HTTP_RAW_POST_DATA. [1] PROS: * save up to 300% on post_data_len memory (on non-form POSTs) * a local siege (c=512/512,

[PHP-DEV] PROPOSAL: temp stream for post_data

2013-08-27 Thread Michael Wallner
Hi, I prepared a patch to replace sapi_globals' request_info post_data and raw_post_data with a temp stream and remove support for HTTP_RAW_POST_DATA. [1] PROS: * save up to 300% on post_data_len memory (on non-form POSTs) * a local siege (c=512/512, 2.4k form/2.2k json) showed no (negative) perf