Re: [PHP-DEV] RFC [Discussion]: Make unserialize() emit a warning for trailing bytes

2023-04-10 Thread Tim Düsterhus
Hi On 3/27/23 19:03, Tim Düsterhus wrote: RFC: Make unserialize() emit a warning for trailing bytes https://wiki.php.net/rfc/unserialize_warn_on_trailing_data Proof of concept implementation is in: https://github.com/php/php-src/pull/9630 The minimum 2 weeks of discussion will be over in a

Re: [PHP-DEV] RFC [Discussion]: Make unserialize() emit a warning for trailing bytes

2023-03-28 Thread Tim Düsterhus
Hi On 3/28/23 09:27, Christian Schneider wrote: Personally, I'd like the unserialize to throw an exception if trailing bytes are detected. If not by default then with the use of the option passed to unserialize function. If that's the desired direction, it makes more sense to emit a

Re: [PHP-DEV] RFC [Discussion]: Make unserialize() emit a warning for trailing bytes

2023-03-28 Thread Christian Schneider
Am 28.03.2023 um 00:22 schrieb Larry Garfield : > On Mon, Mar 27, 2023, at 2:12 PM, Mel Dafert wrote: >> On 27 March 2023 20:20:58 CEST, "Michał Marcin Brzuchalski" >> wrote: >>> Personally, I'd like the unserialize to throw an exception if trailing >>> bytes are detected. >>> If not by default

Re: [PHP-DEV] RFC [Discussion]: Make unserialize() emit a warning for trailing bytes

2023-03-27 Thread Larry Garfield
On Mon, Mar 27, 2023, at 2:12 PM, Mel Dafert wrote: > On 27 March 2023 20:20:58 CEST, "Michał Marcin Brzuchalski" > wrote: >> Personally, I'd like the unserialize to throw an exception if trailing >>bytes are detected. >>If not by default then with the use of the option passed to unserialize

Re: [PHP-DEV] RFC [Discussion]: Make unserialize() emit a warning for trailing bytes

2023-03-27 Thread Mel Dafert
On 27 March 2023 20:20:58 CEST, "Michał Marcin Brzuchalski" wrote: > Personally, I'd like the unserialize to throw an exception if trailing >bytes are detected. >If not by default then with the use of the option passed to unserialize >function. If that's the desired direction, it makes more

Re: [PHP-DEV] RFC [Discussion]: Make unserialize() emit a warning for trailing bytes

2023-03-27 Thread Michał Marcin Brzuchalski
Hi Tim, thanks for the RFC pon., 27 mar 2023 o 19:04 Tim Düsterhus napisał(a): > Hi > > I'm now opening discussion for the RFC "Make unserialize() emit a > warning for trailing bytes": > > > > RFC: Make unserialize() emit a warning for trailing bytes >

[PHP-DEV] RFC [Discussion]: Make unserialize() emit a warning for trailing bytes

2023-03-27 Thread Tim Düsterhus
Hi I'm now opening discussion for the RFC "Make unserialize() emit a warning for trailing bytes": RFC: Make unserialize() emit a warning for trailing bytes https://wiki.php.net/rfc/unserialize_warn_on_trailing_data Proof of concept implementation is in: