Hi again,
OK, I will go ahead and commit the patch + test updates in about 24 hours...
- Matt
- Original Message -
From: "Matt Wilmas"
Sent: Friday, May 29, 2009
Hi all,
- Original Message -
From: "Matt Wilmas"
Sent: Friday, April 10, 2009
Hi Dmitry,
I finally updated the
Hi all,
- Original Message -
From: "Matt Wilmas"
Sent: Friday, April 10, 2009
Hi Dmitry,
I finally updated the patches:
http://realplain.com/php/dval_to_lval.diff
http://realplain.com/php/dval_to_lval_5_3.diff
The patches were updated again, against current CVS (no changes by me).
A
Hi!
Really, I don't understand what it's going to fix (the need of
preserving low bits looks strange for me).
From what I understand the idea of the patch is what we are doing if we
try to convert double that's too big for long into long (please correct
me if I'm talking nonsense here). We'd
I looked into it some time ago.
Really, I don't understand what it's going to fix (the need of
preserving low bits looks strange for me).
Also it breaks ~30 tests.
Thanks. Dmitry.
Johannes Schlüter wrote:
On Fri, 2009-04-10 at 14:45 -0500, Matt Wilmas wrote:
Hi Dmitry,
I finally updated the
On Fri, 2009-04-10 at 14:45 -0500, Matt Wilmas wrote:
> Hi Dmitry,
>
> I finally updated the patches:
> http://realplain.com/php/dval_to_lval.diff
> http://realplain.com/php/dval_to_lval_5_3.diff
Has anybody (Dmitry?) reviewed this or other feedback?
johannes
--
PHP Internals - PHP Runtime D
Hi Dmitry,
I finally updated the patches:
http://realplain.com/php/dval_to_lval.diff
http://realplain.com/php/dval_to_lval_5_3.diff
After seeing how things work on Windows and [new for me] 32- and 64-bit
Linux, there's no longer all that magic stuff I had before. :-) Now the
conversion method
Hi Matt,
I don't really see why we should "preserve the least significant bits"
and I don't think we should support bitwise operations with doubles.
Stas, could you please look into this too.
Thanks. Dmitry.
Matt Wilmas wrote:
Hi Dmitry,
- Original Message -
From: "Dmitry Stogov"
S
Hi Dmitry,
- Original Message -
From: "Dmitry Stogov"
Sent: Thursday, April 02, 2009
Hi Matt,
I tried to look into this issue once again, but I completely misunderstand
why do we need all this magic. Why do we need conversion of positive
double into negative long?
I don't really ha
Hi Matt,
I tried to look into this issue once again, but I completely
misunderstand why do we need all this magic. Why do we need conversion
of positive double into negative long?
I would stay with single DVAL_TO_LVAL() definition and use it in places
instead of (long)Z_DVAL().
#define DVA
