Re: [PHP-DEV] Re: [PECL-DEV] libidn2 extension for php

2011-11-22 Thread David Soria Parra
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/21/2011 01:23 PM, Pierre Joye wrote: > hi, > > After a short talk on IRC, we agreed to go with the solution 1. > > David, Stas, any objection for 5.4? As it adds a new feature it is > actually a bug fix too. - From my side it's okay to add it

[PHP-DEV] Re: [PECL-DEV] libidn2 extension for php

2011-11-22 Thread David Soria Parra
On 2011-11-21, "Gustavo Lopes" wrote: > > -static void php_intl_idn_to(INTERNAL_FUNCTION_PARAMETERS, int mode) > +/* like INTL_CHECK_STATUS, but as a function and varying the name of the > func */ > +static int php_intl_idn_check_status(UErrorCode err, const char *msg, int > mode TSRMLS_DC) >

Re: [PHP-DEV] Re: [PECL-DEV] libidn2 extension for php

2011-11-21 Thread Gustavo Lopes
Em Mon, 21 Nov 2011 12:42:08 -, Hannes Magnusson escreveu: On Mon, Nov 21, 2011 at 13:35, Ferenc Kovacs wrote: * Add a second new parameter, by reference, wherein this extra information is written. * Instead of returning a string, return an array with all the new information. Fr

Re: [PHP-DEV] Re: [PECL-DEV] libidn2 extension for php

2011-11-21 Thread Hannes Magnusson
On Mon, Nov 21, 2011 at 13:35, Ferenc Kovacs wrote: >> >> However there's a little problem. The new interface reports errors via the >> usual ICU mechanism AND it also uses a new structure to pass IDNA specific >> errors. Also, it reports whether the use of the transitional mechanism >> affects th

Re: [PHP-DEV] Re: [PECL-DEV] libidn2 extension for php

2011-11-21 Thread Ferenc Kovacs
> > However there's a little problem. The new interface reports errors via the > usual ICU mechanism AND it also uses a new structure to pass IDNA specific > errors. Also, it reports whether the use of the transitional mechanism > affects the result. So I see only two solutions so that that extra >

Re: [PHP-DEV] Re: [PECL-DEV] libidn2 extension for php

2011-11-21 Thread Pierre Joye
hi, After a short talk on IRC, we agreed to go with the solution 1. David, Stas, any objection for 5.4? As it adds a new feature it is actually a bug fix too. Cheers, On Mon, Nov 21, 2011 at 11:46 AM, Pierre Joye wrote: > Hi Gustavo! > > Thanks for the quick action :) > > I prefer however the

Re: [PHP-DEV] Re: [PECL-DEV] libidn2 extension for php

2011-11-21 Thread Pierre Joye
Hi Gustavo! Thanks for the quick action :) I prefer however the 1st solution so that the code using the function can use transparently the returned value. At some point we may add classes as well, for those interested in more details. Cheers, On Nov 21, 2011 4:53 AM, "Gustavo Lopes" wrote: >

[PHP-DEV] Re: [PECL-DEV] libidn2 extension for php

2011-11-20 Thread Gustavo Lopes
On Fri, 18 Nov 2011 13:12:01 -, Pierre Joye wrote: Possibly the best course of action would be to follow the ICU API and create a new class in the intl extension with labelToASCII (uidna_labelToASCII_UTF8), labelToUnicode (uidna_labelToUnicodeUTF8), nameToASCII (uidna_nameToASCII_UTF8