I have no clue what those 2 sections do either.
But if the number of affected tests is small, then feel free to patch the
tests and/or run-tests.php.
Nuno
-Original Message-
From: zoe slattery
Sent: Tuesday, May 08, 2012 2:06 PM
Subject: [PHP-QA] run-tests.php - GZIP_POST and DEFLAT
Zoe Slattery wrote:
It is a nice patch - but I'm seeing some errors that I don't
understand yet when I use it - like this:
Warning: preg_match(): Compilation failed: missing terminating ] for
character class at offset 5 in /home/zoe/BUILDS/php52/run-tests.php on
line 1609
I'm not having t
It is a nice patch - but I'm seeing some errors that I don't understand
yet when I use it - like this:
Warning: preg_match(): Compilation failed: missing terminating ] for
character class at offset 5 in /home/zoe/BUILDS/php52/run-tests.php on
line 1609
I'm not having the best afternoon :-( -
Marcus Boerger wrote:
Hello Nuno,
Thursday, September 13, 2007, 9:20:51 PM, you wrote:
now i get the issue. It grabbs more than one line! This means
run-tests.php has to be fixed. The whole thing is designed under
the assumption that %s catches no new lines and hence only one
line.
OK, so basically it is impossible to fix the current regex to match what
we
want (I had a quick chat with the PCRE author and he thinks the same).
I propose the following patch:
http://web.ist.utl.pt/nuno.lopes/php_run_tests_%s.txt
The main changes are:
'%s' => '[^\r\n]+'
Nice patch! The onl
Hello Nuno,
Thursday, September 13, 2007, 9:20:51 PM, you wrote:
>>> now i get the issue. It grabbs more than one line! This means
>>> run-tests.php has to be fixed. The whole thing is designed under
>>> the assumption that %s catches no new lines and hence only one
>>> line.
>>
>> That would b
Hi again
On second thoughts - cancel my last two notes - yours is a better fix. :-)
Zoe
Johannes Schlüter wrote:
Hi Nuno,
On Thu, 2007-09-13 at 20:20 +0100, Nuno Lopes wrote:
now i get the issue. It grabbs more than one line! This means
run-tests.php has to be fixed. The whole thing is
..PS - here is a slightly longer explanation of how I got to the idea
that to removing the "s" modifier would be a better fix.
I did a little more work to understand how the regex matching for %s was
working in run-tests.php.
In the current version %s maps to .+? This *should* match one or
Hi guys - There is an alternative patch if you have't already committed
this. The line:
if (preg_match("/^$wanted_re$/s", $output))
can just be changed to remove the "s" modifier, I was working on trying
to fix up the tests and make sure that they all work. The problematic
ones are the php_i
Hi Nuno,
On Thu, 2007-09-13 at 20:20 +0100, Nuno Lopes wrote:
> >> now i get the issue. It grabbs more than one line! This means
> >> run-tests.php has to be fixed. The whole thing is designed under
> >> the assumption that %s catches no new lines and hence only one
> >> line.
> >
> > That would
now i get the issue. It grabbs more than one line! This means
run-tests.php has to be fixed. The whole thing is designed under
the assumption that %s catches no new lines and hence only one
line.
That would be the best answer but I think it's a difficult fix and
whatever it was might break ot
Marcus Boerger wrote:
I meant %s = [^\n]+?
Ah - I should have guessed that. Yes, it solves the problem, but then
running make test gives an extra 7 failing tests - so I need to look at
why they are failing and work out how to fix them.
and continuing our private discussion earlier we might
Hello Zoe,
Tuesday, September 11, 2007, 3:53:12 PM, you wrote:
> Marcus Boerger wrote:
>> Hello Zoe,
>>
>> %s = [\n]+?
> I'm not sure what this would match? I think we need something that
> matches any character but doesn't run over a line end?
> If so it would be more like [.\\n]+? - although
Marcus Boerger wrote:
Hello Zoe,
%s = [\n]+?
I'm not sure what this would match? I think we need something that matches any
character but doesn't run over a line end? If so it would be more like [.\\n]+?
- although this isn't right either (as in, I've tried both and they don't work
:-( ).
Hello Zoe,
%s = [\n]+?
If that affects any test we have to fix those :-)
marcus
Monday, September 10, 2007, 10:02:48 PM, you wrote:
> Marcus Boerger wrote:
>> Hello Zoe,
>>
>> now i get the issue. It grabbs more than one line! This means
>> run-tests.php has to be fixed. The whole thing is
Marcus Boerger wrote:
Hello Zoe,
now i get the issue. It grabbs more than one line! This means
run-tests.php has to be fixed. The whole thing is designed under
the assumption that %s catches no new lines and hence only one
line.
That would be the best answer but I think it's a difficult
Hello Zoe,
now i get the issue. It grabbs more than one line! This means
run-tests.php has to be fixed. The whole thing is designed under
the assumption that %s catches no new lines and hence only one
line.
marcus
Monday, September 10, 2007, 6:03:54 PM, you wrote:
> Hi Marcus
>>
>> why is t
17 matches
Mail list logo
