Re: [PHP-DEV] Re: [RFC] Support internal function return types

2015-02-05 Thread reeze
Thanks a lot! On 5 February 2015 at 16:03, Dmitry Stogov dmi...@zend.com wrote: merged into master with the proposed changes. Thanks. Dmitry. On Thu, Feb 5, 2015 at 9:37 AM, reeze re...@php.net wrote: Hi Dmitry, On 5 February 2015 at 14:31, Dmitry Stogov dmi...@zend.com wrote: Hi

Re: [PHP-DEV] Re: [RFC] Support internal function return types

2015-02-05 Thread Dmitry Stogov
merged into master with the proposed changes. Thanks. Dmitry. On Thu, Feb 5, 2015 at 9:37 AM, reeze re...@php.net wrote: Hi Dmitry, On 5 February 2015 at 14:31, Dmitry Stogov dmi...@zend.com wrote: Hi reeze, The original return type patch was designed to support internal functions as

Re: [PHP-DEV] Re: [RFC] Support internal function return types

2015-02-05 Thread Michael Wallner
On 05/02/15 09:05, reeze wrote: Thanks a lot! On 5 February 2015 at 16:03, Dmitry Stogov dmi...@zend.com wrote: merged into master with the proposed changes. Thanks. Dmitry. Awesome, thank you! -- Regards, Mike -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe,

Re: [PHP-DEV] Re: [RFC] Support internal function return types

2015-02-04 Thread Dmitry Stogov
Hi reeze, The original return type patch was designed to support internal functions as well. So I think, this is just a good addition. Only one note: I'm not sure, if we need the addition check in ZEND_DO_FCALL handler. On one hand it verifies that internal function returns proper result (but

Re: [PHP-DEV] Re: [RFC] Support internal function return types

2015-02-04 Thread reeze
Hi Dmitry, On 5 February 2015 at 14:31, Dmitry Stogov dmi...@zend.com wrote: Hi reeze, The original return type patch was designed to support internal functions as well. So I think, this is just a good addition. Yes :) Only one note: I'm not sure, if we need the addition check in

[PHP-DEV] Re: [RFC] Support internal function return types

2015-02-04 Thread reeze
PS: There is no enough unit tests to cover all of the branches, if we want then I have to add a bunch of for testing functions and classes in ZEND_DEBUG, what is the better way? On 5 February 2015 at 11:54, reeze re...@php.net wrote: Hi all, RFC: