Re: [PHP-DEV] Re: Faster zend sorting implementation

2015-01-14 Thread Stanislav Malyshev
Hi! I made a PR here: https://github.com/php/php-src/pull/999 for reviewing in benchmark this can brings more than 30% performance gain in array_sort etc functions. tests fails are related to non-stable vs stable sorting difference. anyway, I feel it's better to ask you

Re: [PHP-DEV] Re: Faster zend sorting implementation

2015-01-14 Thread Pierre Joye
On Wed, Jan 14, 2015 at 9:09 PM, Stanislav Malyshev smalys...@gmail.com wrote: Hi! I made a PR here: https://github.com/php/php-src/pull/999 for reviewing in benchmark this can brings more than 30% performance gain in array_sort etc functions. tests fails are related to

Re: [PHP-DEV] Re: Faster zend sorting implementation

2015-01-14 Thread Xinchen Hui
Hey: On Thu, Jan 15, 2015 at 7:52 AM, Pierre Joye pierre@gmail.com wrote: On Wed, Jan 14, 2015 at 9:09 PM, Stanislav Malyshev smalys...@gmail.com wrote: Hi! I made a PR here: https://github.com/php/php-src/pull/999 for reviewing in benchmark this can brings more than 30%

[PHP-DEV] Re: Faster zend sorting implementation

2015-01-14 Thread Xinchen Hui
Hey: I made a PR here: https://github.com/php/php-src/pull/999 for reviewing in benchmark this can brings more than 30% performance gain in array_sort etc functions. tests fails are related to non-stable vs stable sorting difference. anyway, I feel it's better to ask you to do

[PHP-DEV] Re: Faster zend sorting implementation

2015-01-14 Thread Dmitry Stogov
I don't see big problems committing this. In some cases new sort() functions may provide different results, but they are still valid, because the order of equal elements after sort is not defined. Thanks. Dmitry. On Wed, Jan 14, 2015 at 12:59 PM, Xinchen Hui larue...@php.net wrote: Hey:

Re: [PHP-DEV] Re: Faster zend sorting implementation

2015-01-05 Thread Julien Pauli
On Mon, Jan 5, 2015 at 6:09 PM, Xinchen Hui larue...@php.net wrote: On Tue, Jan 6, 2015 at 1:08 AM, Xinchen Hui larue...@php.net wrote: Hey: I was working on zend_qsort improvement. but I got a problem need to be disscussed with you fist.. first as we know, previously

[PHP-DEV] Re: Faster zend sorting implementation

2015-01-05 Thread Xinchen Hui
On Tue, Jan 6, 2015 at 1:08 AM, Xinchen Hui larue...@php.net wrote: Hey: I was working on zend_qsort improvement. but I got a problem need to be disscussed with you fist.. first as we know, previously zend_qsort is not a stable sorting algo. my draft patch (which already

Re: [PHP-DEV] Re: Faster zend sorting implementation

2015-01-05 Thread Xinchen Hui
Hey: On Jan 6, 2015, at 1:27 AM, Julien Pauli jpa...@php.net wrote: On Mon, Jan 5, 2015 at 6:09 PM, Xinchen Hui larue...@php.net wrote: On Tue, Jan 6, 2015 at 1:08 AM, Xinchen Hui larue...@php.net wrote: Hey: I was working on zend_qsort improvement. but I got a problem need to

Re: [PHP-DEV] Re: Faster zend sorting implementation

2015-01-05 Thread Sanford Whiteman
Sounds more like a bugfix to me and def'ly an acceptable BC break in either case. The behavior isn't specified and if anything I would assume there _wouldn't_ be a swap with SORT_FLAG_CASE on. Interesting though that many sorting examples (across languages) sidestep this clearly common case. --