Re: [PHP-DEV] Re: JSON changes in 5.3/5.4

2012-07-02 Thread Max Benson
Johannes Schlüter johannes at schlueters.de writes: I think in 5.3 we don't need changes. 5.3 is a stable stable stable branch. Fixing bugs, ok, changing behavior: No go. I haven't looked at it in detail, though. johannes Indeed, 5.3 seems very stable. We ran many tests. Regards, Max

[PHP-DEV] Re: JSON changes in 5.3/5.4

2012-07-01 Thread Nikita Popov
On Sun, Jul 1, 2012 at 1:51 AM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! If you are okay with the changes in principle, I will fix the remaining issues asap. If you think that the changes are too intrusive for release branches, I'll gladly revert them for 5.3/5.4. I didn't quite

[PHP-DEV] Re: JSON changes in 5.3/5.4

2012-06-30 Thread Nikita Popov
On Sun, Jul 1, 2012 at 12:59 AM, Stas Malyshev smalys...@sugarcrm.com wrote: Hi! I see that there were significant changes committed to JSON extension in 5.3 and 5.4 recently. These changes modify json_encode behavior, break tests (pass001.1_64bit.phpt does not work anymore for me), are not

[PHP-DEV] Re: JSON changes in 5.3/5.4

2012-06-30 Thread Johannes Schlüter
On Sun, 2012-07-01 at 01:14 +0200, Nikita Popov wrote: If you are okay with the changes in principle, I will fix the remaining issues asap. If you think that the changes are too intrusive for release branches, I'll gladly revert them for 5.3/5.4. I didn't quite expect that there will be so

[PHP-DEV] Re: JSON changes in 5.3/5.4

2012-06-30 Thread Nikita Popov
On Sun, Jul 1, 2012 at 1:27 AM, Johannes Schlüter johan...@schlueters.de wrote: I think in 5.3 we don't need changes. 5.3 is a stable stable stable branch. Fixing bugs, ok, changing behavior: No go. Agreed. One question: When I revert the changes to 5.3 should I also revert the original change

[PHP-DEV] Re: JSON changes in 5.3/5.4

2012-06-30 Thread Stas Malyshev
Hi! If you are okay with the changes in principle, I will fix the remaining issues asap. If you think that the changes are too intrusive for release branches, I'll gladly revert them for 5.3/5.4. I didn't quite expect that there will be so many changes. I think changes with adding new