[PHP-DEV] Re: PR1739

2016-01-28 Thread Yasuo Ohgaki
Hi Anatol, On Thu, Jan 28, 2016 at 1:33 PM, Yasuo Ohgaki wrote: > On Thu, Jan 28, 2016 at 12:48 PM, Yasuo Ohgaki wrote: >> >> https://github.com/php/php-src/pull/1739 >> This PR is good one. It opens handler first, then proceeds. >> It fixes save handler crash also. >> >> The PR does not break o

[PHP-DEV] Re: PR1739

2016-01-27 Thread Yasuo Ohgaki
Hi Anatol, On Thu, Jan 28, 2016 at 12:48 PM, Yasuo Ohgaki wrote: > > https://github.com/php/php-src/pull/1739 > This PR is good one. It opens handler first, then proceeds. > It fixes save handler crash also. > > The PR does not break our tests and PHP7 only fix. However, It changes > handler exec