Re: [PHP-DEV] Re: Unicode support for *printf()

2006-12-20 Thread Andrei Zmievski
Committed. On Dec 19, 2006, at 6:36 PM, Matt Wilmas wrote: Hi Andrei, Yeah, I see the patch you committed also included the changes that were made since my reply yesterday... I've attached a patch that removes a few lines that aren't present in the non-Unicode version. Matt - Origi

Re: [PHP-DEV] Re: Unicode support for *printf()

2006-12-19 Thread Matt Wilmas
Hi Andrei, Yeah, I see the patch you committed also included the changes that were made since my reply yesterday... I've attached a patch that removes a few lines that aren't present in the non-Unicode version. Matt - Original Message - From: "Andrei Zmievski" Sent: Tuesday, December

Re: [PHP-DEV] Re: Unicode support for *printf()

2006-12-19 Thread Andrei Zmievski
Is this better? Index: ext/standard/formatted_print.c === RCS file: /repository/php-src/ext/standard/formatted_print.c,v retrieving revision 1.89 diff -p -u -r1.89 formatted_print.c --- ext/standard/formatted_print.c 18 Dec 2006

Re: [PHP-DEV] Re: Unicode support for *printf()

2006-12-18 Thread Matt Wilmas
Hi Andrei, Just a couple things I noticed in _appenddouble... In the first switch (), 'F' is being changed to 'f', and in the second switch, 'F' needs to be moved down with 'f'. Those changes were just made in v1.89 of the file. Matt - Original Message - From: "Andrei Zmievski" Sent:

Re: [PHP-DEV] Re: Unicode support for *printf()

2006-12-18 Thread Andrei Zmievski
The update patch is attached. If there are no objections, I'd like to commit. -Andrei Index: ext/standard/formatted_print.c === RCS file: /repository/php-src/ext/standard/formatted_print.c,v retrieving revision 1.89 diff -p -u -r1.

[PHP-DEV] Re: Unicode support for *printf()

2006-12-15 Thread Sara Golemon
> I know we had discussion about *fprintf() on IRC, > but I'm still not clear on some stuff. > > Sara, could you please explain again why UG(unicode) > should not be used as the selection for > php_formatted_print/php_u_formatted_print? I > bet a few of us are hazy on the streams Unicode/binary >

[PHP-DEV] Re: Unicode support for *printf()

2006-12-12 Thread Andrei Zmievski
I know we had discussion about *fprintf() on IRC, but I'm still not clear on some stuff. Sara, could you please explain again why UG(unicode) should not be used as the selection for php_formatted_print/php_u_formatted_print? I bet a few of us are hazy on the streams Unicode/binary details,