[PHP-DEV] Re: libmbfl API changes in PHP 7.3

2018-07-11 Thread Jan Ehrhardt
Jan Ehrhardt in php.internals (Tue, 10 Jul 2018 15:39:39 +0200): >"Christoph M. Becker" in php.internals (Tue, 10 Jul 2018 12:04:10 >+0200): >>Have you tried to convert the first two arguments via mbfl_no2encoding()[1]? > >It compiles, but segfaults in 1 test on this line >https://github.com/php/pe

[PHP-DEV] Re: libmbfl API changes in PHP 7.3

2018-07-10 Thread Jan Ehrhardt
"Christoph M. Becker" in php.internals (Tue, 10 Jul 2018 12:04:10 +0200): >Have you tried to convert the first two arguments via mbfl_no2encoding()[1]? It compiles, but segfaults in 1 test on this line https://github.com/php/pecl-mail-mailparse/blob/master/mailparse.c#L1466 Unhandled exception at

[PHP-DEV] Re: libmbfl API changes in PHP 7.3

2018-07-10 Thread Christoph M. Becker
On 10.07.2018 at 10:55, Jan Ehrhardt wrote: > Jan Ehrhardt in php.internals (Tue, 10 Jul 2018 10:30:33 +0200): >> The change was introduced in this commit by nikic: >> https://github.com/php/php-src/commit/b3c1d9d1118438a3dae357db2b39ca5cfa25 > > What strikes me: this change was made to the m

[PHP-DEV] Re: libmbfl API changes in PHP 7.3

2018-07-10 Thread Christoph M. Becker
On 10.07.2018 at 10:30, Jan Ehrhardt wrote: > While trying to make the mailparse extension fit for PHP 7.3 I ran into > changes in the libmbfl API. I cannot find any documentation on this > change. > > The change was introduced in this commit by nikic: > https://github.com/php/php-src/commit/b3c1

[PHP-DEV] Re: libmbfl API changes in PHP 7.3

2018-07-10 Thread Jan Ehrhardt
Jan Ehrhardt in php.internals (Tue, 10 Jul 2018 10:30:33 +0200): >The change was introduced in this commit by nikic: >https://github.com/php/php-src/commit/b3c1d9d1118438a3dae357db2b39ca5cfa25 What strikes me: this change was made to the master branch almost a year ago, at the time PHP 7.2.0 B