Re: [PHP-DEV] Reflection changes due to allow null + false as standalone types RFC

2022-04-08 Thread G. P. B.
I have just merged the PR with the amended Reflection changes: https://github.com/php/php-src/commit/6039c07a3afd64a42c9b9f1ed994ca971db67a1e Best regards, George P. Banyard

Re: [PHP-DEV] Reflection changes due to allow null + false as standalone types RFC

2022-04-06 Thread Guilliam Xavier
Hi George, > https://github.com/php/php-src/pull/7546#discussion_r837900447 Thanks for asking (even if voted). On Tue, Apr 5, 2022 at 2:01 PM Marco Pivetta wrote: > Probably best with consistency? > > > - Ignore the Reflection changes of the RFC and align the union type with > the current beh

Re: [PHP-DEV] Reflection changes due to allow null + false as standalone types RFC

2022-04-05 Thread Marco Pivetta
Probably best with consistency? > - Ignore the Reflection changes of the RFC and align the union type with the current behaviour This one, specifically. I'd love to see all nullable types become `ReflectionUnionType(ReflectionNamedType($t), ReflectionNamedType(null))`, but that would be a BC br

[PHP-DEV] Reflection changes due to allow null + false as standalone types RFC

2022-04-05 Thread G. P. B.
Hello internals, During the review of the implementation of the RFC which introduces null and false as standalone types there has been a point raised about the changes made to reflection. [1] The current implementation is what follows the RFC, namely to make false|null return a ReflectionUnionTyp