Re: [PHP-DEV] Set register_argc_argv to Off by default

2023-11-09 Thread G. P. B.
On Wed, 8 Nov 2023 at 16:59, Thomas Chauchefoin < thomas.chauchef...@sonarsource.com> wrote: > Thank you for your early feedback on this suggestion. Without rushing > things, I assume that the next step for me would be to draft an RFC to > formalize this change? > The change seems to be uncontrov

Re: [PHP-DEV] Set register_argc_argv to Off by default

2023-11-08 Thread Thomas Chauchefoin via internals
On Tue, Nov 7, 2023 at 11:46 AM Sebastian Bergmann wrote: > Am 07.11.2023 um 11:33 schrieb Thomas Chauchefoin via internals: > > For instance, the official Docker image has it on [2]. > > "Official" is relative here. That image is maintained by (the) Docker > (community), it is not maintained by t

Re: [PHP-DEV] Set register_argc_argv to Off by default

2023-11-07 Thread Matteo Beccati
Hi, Il 07/11/2023 14:13, Kévin Dunglas ha scritto: This change seems reasonable to me: safer, with little chance of breaking things, and easy to reverse for the end user by changing a single parameter. /me runs to remove the 16-years old "register_argc_argv = on" check from the web installer

Re: [PHP-DEV] Set register_argc_argv to Off by default

2023-11-07 Thread G. P. B.
On Tue, 7 Nov 2023 at 10:33, Thomas Chauchefoin via internals < internals@lists.php.net> wrote: > Hey, > > I recently opened an issue on GitHub [1] to discuss setting > register_argc_argv to Off by default for all SAPIs but cli, embed, and > phpdbg. Ilija Tovilo suggested including this change in

Re: [PHP-DEV] Set register_argc_argv to Off by default

2023-11-07 Thread Kévin Dunglas
This change seems reasonable to me: safer, with little chance of breaking things, and easy to reverse for the end user by changing a single parameter.

Re: [PHP-DEV] Set register_argc_argv to Off by default

2023-11-07 Thread Sebastian Bergmann
Am 07.11.2023 um 11:33 schrieb Thomas Chauchefoin via internals: For instance, the official Docker image has it on [2]. "Official" is relative here. That image is maintained by (the) Docker (community), it is not maintained by the PHP project. -- PHP Internals - PHP Runtime Development Maili

[PHP-DEV] Set register_argc_argv to Off by default

2023-11-07 Thread Thomas Chauchefoin via internals
Hey, I recently opened an issue on GitHub [1] to discuss setting register_argc_argv to Off by default for all SAPIs but cli, embed, and phpdbg. Ilija Tovilo suggested including this change in 8.4.0. Even though most downstream distributions already turn it off, that's not the case everywhere. For