Jayachandran [mailto:[EMAIL PROTECTED]
Sent: Thursday, December 16, 2004 6:57 AM
To: Binam, Jesse; [EMAIL PROTECTED]
Subject: Re: [PHP-DEV] ftp_get_resp ftp_get_conv functions
Hi Jesse,
2500*4096 = 10M on ftpbuf would be too much for the user who is not
interested in this functionality
Hi Jesse,
2500*4096 = 10M on ftpbuf would be too much for the user who is not
interested in this functionality.
It should be allocating the memory dynamically instead of hardcoding the
size to 2500.
This need to happen only when requested, may be some option argument to
ftp_connect whether to
performance hit?
Regretfully ignorant,
Jess
-Original Message-
From: Kamesh Jayachandran [mailto:[EMAIL PROTECTED]
Sent: Thursday, December 16, 2004 6:57 AM
To: Binam, Jesse; [EMAIL PROTECTED]
Subject: Re: [PHP-DEV] ftp_get_resp ftp_get_conv functions
Hi Jesse,
2500*4096 = 10M on ftpbuf
Jayachandran [mailto:[EMAIL PROTECTED]
Sent: Thursday, December 16, 2004 6:57 AM
To: Binam, Jesse; [EMAIL PROTECTED]
Subject: Re: [PHP-DEV] ftp_get_resp ftp_get_conv functions
Hi Jesse,
2500*4096 = 10M on ftpbuf would be too much for the user who is not
interested in this functionality
The attached diff adds 2 ftp functions. I read the
README.SUBMITTING_PATCH and went thru all the steps, but there are no
tests for ftp, and I didn't understand how to update the docs. So if
someone would like to help me with that, great.
Basically, I modifed ftpbuf_t adding a 2 dimensional array
