Re: [PHP-DEV] ksort breaking change

2022-08-26 Thread Sara Golemon
On Fri, Aug 26, 2022 at 11:53 AM Christian Schneider wrote: > Am 26.08.2022 um 18:28 schrieb Sara Golemon : > > What I can see is two noble, but conflicting ideals: > > 1/ sort() and ksort() should be consistent about their sorting > algorithms. > > I think we can all agree about that in the

Re: [PHP-DEV] ksort breaking change

2022-08-26 Thread Christian Schneider
Am 26.08.2022 um 18:28 schrieb Sara Golemon : > What I can see is two noble, but conflicting ideals: > 1/ sort() and ksort() should be consistent about their sorting algorithms. > I think we can all agree about that in the ideal case, at least. > 2/ Behavior within a minor release should be

Re: [PHP-DEV] ksort breaking change

2022-08-26 Thread juan carlos morales
Oh! My bad. Nice work! Cheers El vie., 26 de agosto de 2022 16:51, Tim Düsterhus escribió: > Hi > > On 8/26/22 16:15, juan carlos morales wrote: > > Seems like we Don't Have tests for the function or we should enhance the > > existing ones. If We would Have proper tests the FIX would break it

Re: [PHP-DEV] ksort breaking change

2022-08-26 Thread Tim Düsterhus
Hi On 8/26/22 16:15, juan carlos morales wrote: Seems like we Don't Have tests for the function or we should enhance the existing ones. If We would Have proper tests the FIX would break it (as I Don't see tests in the fix itself).That is why I say so. Various tests were adjusted in:

Re: [PHP-DEV] ksort breaking change

2022-08-26 Thread juan carlos morales
Seems like we Don't Have tests for the function or we should enhance the existing ones. If We would Have proper tests the FIX would break it (as I Don't see tests in the fix itself).That is why I say so. I Am not in my computer atm. I Will check this later El vie., 26 de agosto de 2022

Re: [PHP-DEV] ksort breaking change

2022-08-26 Thread Christian Schneider
Am 26.08.2022 um 14:19 schrieb Christoph M. Becker : > On 26.08.2022 at 05:15, Go Kudo wrote: > >> In the actively supported version of PHP, `ksort()` has been modified to >> include BC Break. >> >> https://github.com/php/php-src/issues/9296 >> >> This may seem like an appropriate bug fix, but

[PHP-DEV] ksort breaking change

2022-08-25 Thread Go Kudo
Hi Internals. In the actively supported version of PHP, `ksort()` has been modified to include BC Break. https://github.com/php/php-src/issues/9296 This may seem like an appropriate bug fix, but it is a clear BC Break. I think this change should only be introduced in PHP 8.2 and later.