Re: [PHP-DEV] libxml bit field

2013-02-13 Thread Dmitry Stogov
Yeah. Bit reset is better. I'll update it. Thanks. Dmitry. On Wed, Feb 13, 2013 at 9:51 PM, Ard Biesheuvel wrote: > Hey all, > > In commit http://git.php.net/?p=php-src.git;a=commitdiff;h=afe98b78 > I just noticed two instances of the following: > > ctxt->options -= XML_PARSE_DTDLOAD; > > Should

[PHP-DEV] libxml bit field

2013-02-13 Thread Ard Biesheuvel
Hey all, In commit http://git.php.net/?p=php-src.git;a=commitdiff;h=afe98b78 I just noticed two instances of the following: ctxt->options -= XML_PARSE_DTDLOAD; Shouldn't that be ctxt->options &= ~XML_PARSE_DTDLOAD; or am I missing something? -- Ard. -- PHP Internals - PHP Runtime Developme