Re: [PHP-DEV] new json, push generated file?

2015-02-22 Thread Anatol Belski
Hi Jakub, On Tue, February 17, 2015 17:53, Anatol Belski wrote: Hi Jakub, On Sun, February 15, 2015 21:18, Jakub Zelenka wrote: On Wed, Feb 11, 2015 at 11:56 AM, Jakub Zelenka bu...@php.net wrote: I would like to push the the bison tab files shortly as the majority of people in this

Re: [PHP-DEV] new json, push generated file?

2015-02-22 Thread Jakub Zelenka
Hi Anatol, On Sun, Feb 22, 2015 at 6:09 PM, Anatol Belski anatol@belski.net wrote: FYI I had to downgrade re2c to 0.13.6 as the latest randomly crashes. Ok. :) There are no differences in the generated DFA so it's not a problem for me to use 0.13.6 too. The preferred versions are more

Re: [PHP-DEV] new json, push generated file?

2015-02-17 Thread Anatol Belski
Hi Jakub, On Sun, February 15, 2015 21:18, Jakub Zelenka wrote: On Wed, Feb 11, 2015 at 11:56 AM, Jakub Zelenka bu...@php.net wrote: I would like to push the the bison tab files shortly as the majority of people in this thread (including me) are for having them in the repo. The only

Re: [PHP-DEV] new json, push generated file?

2015-02-15 Thread Jakub Zelenka
On Wed, Feb 11, 2015 at 11:56 AM, Jakub Zelenka bu...@php.net wrote: I would like to push the the bison tab files shortly as the majority of people in this thread (including me) are for having them in the repo. The only thing that I would like is to have a specific version in the repo to

Re: [PHP-DEV] new json, push generated file?

2015-02-11 Thread Jakub Zelenka
Hi Anatol, On Tue, Feb 10, 2015 at 3:35 PM, Anatol Belski anatol@belski.net wrote: Maybe it'd be worth it to move one step after another, see what features can be implemented and how do they improve? Maybe they'll be so crucial to even make a special case that one can say - yeah, don't

Re: [PHP-DEV] new json, push generated file?

2015-02-10 Thread Anatol Belski
On Tue, February 10, 2015 14:15, Jakub Zelenka wrote: Hi Anatol, On Tue, Feb 10, 2015 at 12:24 PM, Anatol Belski anatol@belski.net wrote: It's actually so that there is a range of tool versions supported. That means any version within the range should be valid for use. If another

Re: [PHP-DEV] new json, push generated file?

2015-02-10 Thread Jakub Zelenka
Hey On Tue, Feb 10, 2015 at 2:47 AM, Xinchen Hui larue...@php.net wrote: why make this thing in this way complicated? why not just simply include the generated files as others did? First of all the others did exactly what I have already done. :) It means they included re2c generated files

Re: [PHP-DEV] new json, push generated file?

2015-02-10 Thread Jakub Zelenka
Hi Anatol, On Tue, Feb 10, 2015 at 12:24 PM, Anatol Belski anatol@belski.net wrote: It's actually so that there is a range of tool versions supported. That means any version within the range should be valid for use. If another range of versions is defined, so it's obviously to follow it.

Re: [PHP-DEV] new json, push generated file?

2015-02-10 Thread Anatol Belski
Hi Jakub, On Tue, February 10, 2015 12:56, Jakub Zelenka wrote: Hey On Tue, Feb 10, 2015 at 2:47 AM, Xinchen Hui larue...@php.net wrote: why make this thing in this way complicated? why not just simply include the generated files as others did? First of all the others did exactly what

Re: [PHP-DEV] new json, push generated file?

2015-02-09 Thread Anatol Belski
Hi, On Mon, February 9, 2015 07:33, Xinchen Hui wrote: Hey: On Mon, Feb 9, 2015 at 1:44 PM, Pierre Joye pierre@gmail.com wrote: On Mon, Feb 9, 2015 at 11:10 AM, Xinchen Hui larue...@php.net wrote: Hey: On Mon, Feb 9, 2015 at 10:40 AM, Pierre Joye pierre@gmail.com wrote:

Re: [PHP-DEV] new json, push generated file?

2015-02-09 Thread Jakub Zelenka
On Mon, Feb 9, 2015 at 9:18 AM, Anatol Belski anatol@belski.net wrote: Hi, On Mon, February 9, 2015 07:33, Xinchen Hui wrote: Hey: On Mon, Feb 9, 2015 at 1:44 PM, Pierre Joye pierre@gmail.com wrote: On Mon, Feb 9, 2015 at 11:10 AM, Xinchen Hui larue...@php.net wrote:

Re: [PHP-DEV] new json, push generated file?

2015-02-09 Thread Xinchen Hui
Hey: On Tue, Feb 10, 2015 at 3:19 AM, Jakub Zelenka bu...@php.net wrote: On Mon, Feb 9, 2015 at 1:55 PM, Pierre Joye pierre@gmail.com wrote: I still think it is better to have this file applied. It is not like they will change every 2nd day. Hi, I think that I might have solution for

Re: [PHP-DEV] new json, push generated file?

2015-02-09 Thread Pierre Joye
On Tue, Feb 10, 2015 at 9:47 AM, Xinchen Hui larue...@php.net wrote: why make this thing in this way complicated? why not just simply include the generated files as others did? There are cases where it is configure dependent so not including them makes sense. I do not recognize this case with

Re: [PHP-DEV] new json, push generated file?

2015-02-09 Thread Jakub Zelenka
On Mon, Feb 9, 2015 at 7:22 PM, Nikita Popov nikita@gmail.com wrote: On Mon, Feb 9, 2015 at 3:40 AM, Pierre Joye pierre@gmail.com wrote: hi, Should we push json_parser.tab.c? Which is generated (re2c), just like what is done in date or other? We do not include bison generated

Re: [PHP-DEV] new json, push generated file?

2015-02-09 Thread Pierre Joye
On Feb 9, 2015 4:46 PM, Jakub Zelenka bu...@php.net wrote: On Mon, Feb 9, 2015 at 9:18 AM, Anatol Belski anatol@belski.net wrote: Hi, On Mon, February 9, 2015 07:33, Xinchen Hui wrote: Hey: On Mon, Feb 9, 2015 at 1:44 PM, Pierre Joye pierre@gmail.com wrote: On Mon,

Re: [PHP-DEV] new json, push generated file?

2015-02-09 Thread Jakub Zelenka
On Mon, Feb 9, 2015 at 1:55 PM, Pierre Joye pierre@gmail.com wrote: I still think it is better to have this file applied. It is not like they will change every 2nd day. Hi, I think that I might have solution for this and also for my another build problem which is re2c version. I have

Re: [PHP-DEV] new json, push generated file?

2015-02-09 Thread Nikita Popov
On Mon, Feb 9, 2015 at 3:40 AM, Pierre Joye pierre@gmail.com wrote: hi, Should we push json_parser.tab.c? Which is generated (re2c), just like what is done in date or other? We do not include bison generated files in the git repo, because bison is already a dependency for building PHP

Re: [PHP-DEV] new json, push generated file?

2015-02-08 Thread Xinchen Hui
Hey: On Mon, Feb 9, 2015 at 10:40 AM, Pierre Joye pierre@gmail.com wrote: hi, Should we push json_parser.tab.c? Which is generated (re2c), just like what is done in date or other? I think we should, and also use a better name...(.tab.c?) thanks Cheers, -- Pierre @pierrejoye |

Re: [PHP-DEV] new json, push generated file?

2015-02-08 Thread Stanislav Malyshev
Hi! Should we push json_parser.tab.c? Which is generated (re2c), just like what is done in date or other? I think we should, otherwise building from release package without re2c would be impossible, and I think before it was possible. In any case, we should be consistent - if we commit

Re: [PHP-DEV] new json, push generated file?

2015-02-08 Thread Pierre Joye
On Mon, Feb 9, 2015 at 11:10 AM, Xinchen Hui larue...@php.net wrote: Hey: On Mon, Feb 9, 2015 at 10:40 AM, Pierre Joye pierre@gmail.com wrote: hi, Should we push json_parser.tab.c? Which is generated (re2c), just like what is done in date or other? I think we should, and also use a

Re: [PHP-DEV] new json, push generated file?

2015-02-08 Thread Xinchen Hui
Hey: On Mon, Feb 9, 2015 at 1:44 PM, Pierre Joye pierre@gmail.com wrote: On Mon, Feb 9, 2015 at 11:10 AM, Xinchen Hui larue...@php.net wrote: Hey: On Mon, Feb 9, 2015 at 10:40 AM, Pierre Joye pierre@gmail.com wrote: hi, Should we push json_parser.tab.c? Which is generated (re2c),

[PHP-DEV] new json, push generated file?

2015-02-08 Thread Pierre Joye
hi, Should we push json_parser.tab.c? Which is generated (re2c), just like what is done in date or other? Cheers, -- Pierre @pierrejoye | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php