On Mon, Jul 1, 2019 at 4:09 PM Scott Dutton wrote:
> Hi all
>
> I have made a PR for 7.4 for just the ignoring invalid input. I will
> open a similar one for PHP 8.
>
> https://github.com/php/php-src/pull/4328
>
> All tests have been fixed for linux, there is one failure for windows
> which I
Hi all
I have made a PR for 7.4 for just the ignoring invalid input. I will
open a similar one for PHP 8.
https://github.com/php/php-src/pull/4328
All tests have been fixed for linux, there is one failure for windows
which I am looking in to.
Voting ends in a few days time so last chance
Hi Chu,
Its currently coded to treat that as 'ff' so any odd amount of '-'
makes it negative, and any even amount is positive.
Thanks
Scott
On 19.06.2019 14:12, CHU Zhaowei wrote:
Hi Scott,
Could you clarify what will happen if multiple negative sign occurs.
I didn't find it in the RFC.
Hi Scott,
Could you clarify what will happen if multiple negative sign occurs. I didn't
find it in the RFC.
e.g. base_convert('--ff', 16, 10)
Thanks,
CHU Zhaowei
> -Original Message-
> From: Scott Dutton
> Sent: Wednesday, June 19, 2019 3:24 PM
> To: internals@lists.php.net
> Subject:
Ah thats brilliant, I will take a look at updating the tests when I
split the PR tomorrow
Thanks Nikita
Scott
On 19.06.2019 09:13, Nikita Popov wrote:
On Wed, Jun 19, 2019 at 10:06 AM Scott Dutton
wrote:
Hi Joe,
I will have a look at splitting the PR, I am not at a computer where
i
On Wed, Jun 19, 2019 at 10:06 AM Scott Dutton wrote:
> Hi Joe,
>
> I will have a look at splitting the PR, I am not at a computer where i
> can code today though so will be tomorrow at the earliest.
>
> The Negative numbers will be a fair amount of work to make the tests
> pass, would this still
Hi Joe,
I will have a look at splitting the PR, I am not at a computer where i
can code today though so will be tomorrow at the earliest.
The Negative numbers will be a fair amount of work to make the tests
pass, would this still need to be done if the RFC doesnt pass ? I am
happy to do
It will likely be easier if the Allow negative numbers implementation
(targetting master only) is entirely separate from the Error on ignored
characters implementation,.
Cheers
Joe
On Wed, 19 Jun 2019 at 09:56, Joe Watkins wrote:
> There should probably be a PR targeting 7.4 with the
There should probably be a PR targeting 7.4 with the implementation of
"Error on ignored characters" as proposed for 7.4, and a PR targeting
master implementing "Error on ignored characters" with exception change and
implementing "Allow negative arguments".
None of these PR's should cause tests
Hi Joe,
I will take a look at conflicts. The failures are extreme value checks
which are a result of allowing the negative numbers. If the negative
numbers one passes I will fix all tests and add some more for the
negative values. The tests fail because of the unsigned -> signed change
(but
The implementation of this does not look ready, there are conflicts so I
can't test it locally, but last time CI ran there were many failures.
Cheers
Joe
On Wed, 19 Jun 2019 at 09:24, Scott Dutton wrote:
> Hi all
>
> I have put my RFC base convert changes to vote this morning
>
>
11 matches
Mail list logo
