RE: [PHP-DEV] Accessors v2 Patch

2011-12-12 Thread Clint M Priest
[mailto:guilhermebla...@gmail.com] Sent: Sunday, December 11, 2011 10:35 PM To: Will Fitch Cc: Clint M Priest; Pierre Joye; internals@lists.php.net Subject: Re: [PHP-DEV] Accessors v2 Patch hi Will, That's what I've been thinking about. I have a special necessity to overload a class in a Proxy

RE: [PHP-DEV] Accessors v2 Patch

2011-12-12 Thread Johannes Schlüter
@lists.php.net Subject: Re: [PHP-DEV] Accessors v2 Patch oh right, I missed them. Yes, so it is covered as well :) On Mon, Dec 12, 2011 at 1:42 AM, Clint M Priest cpri...@zerocue.com wrote: There are already two tests against private read and private write, should I add two for protected as well

Re: [PHP-DEV] Accessors v2 Patch

2011-12-12 Thread guilhermebla...@gmail.com
less details to make sense. johannes -Original Message- From: Pierre Joye [mailto:pierre@gmail.com] Sent: Sunday, December 11, 2011 6:47 PM To: Clint M Priest Cc: internals@lists.php.net Subject: Re: [PHP-DEV] Accessors v2 Patch oh right, I missed them. Yes, so it is covered

RE: [PHP-DEV] Accessors v2 Patch

2011-12-12 Thread Clint M Priest
: internals@lists.php.net Subject: Re: [PHP-DEV] Accessors v2 Patch oh right, I missed them. Yes, so it is covered as well :) On Mon, Dec 12, 2011 at 1:42 AM, Clint M Priest cpri...@zerocue.com wrote: There are already two tests against private read and private write, should I add two

Re: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread Will Fitch
Much better implementation. As for the failed tests, I would double check and make sure you don't have any stray debug statements (e.g. printf). Sent from my iPhone On Dec 11, 2011, at 2:27 PM, Clint M Priest cpri...@zerocue.com wrote:

RE: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread Clint M Priest
PM To: Clint M Priest Cc: internals@lists.php.net Subject: Re: [PHP-DEV] Accessors v2 Patch Much better implementation. As for the failed tests, I would double check and make sure you don't have any stray debug statements (e.g. printf). Sent from my iPhone On Dec 11, 2011, at 2:27 PM, Clint M

Re: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread Pierre Joye
[mailto:will.fi...@gmail.com] Sent: Sunday, December 11, 2011 1:41 PM To: Clint M Priest Cc: internals@lists.php.net Subject: Re: [PHP-DEV] Accessors v2 Patch Much better implementation. As for the failed tests, I would double check and make sure you don't have any stray debug statements (e.g. printf

RE: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread Clint M Priest
: Will Fitch [mailto:will.fi...@gmail.com] Sent: Sunday, December 11, 2011 1:41 PM To: Clint M Priest Cc: internals@lists.php.net Subject: Re: [PHP-DEV] Accessors v2 Patch Much better implementation. As for the failed tests, I would double check and make sure you don't have any stray debug

Re: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread Pierre Joye
oh right, I missed them. Yes, so it is covered as well :) On Mon, Dec 12, 2011 at 1:42 AM, Clint M Priest cpri...@zerocue.com wrote: There are already two tests against private read and private write, should I add two for protected as well? Cheers, -- Pierre @pierrejoye |

RE: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread Clint M Priest
To: Clint M Priest Cc: internals@lists.php.net Subject: Re: [PHP-DEV] Accessors v2 Patch oh right, I missed them. Yes, so it is covered as well :) On Mon, Dec 12, 2011 at 1:42 AM, Clint M Priest cpri...@zerocue.com wrote: There are already two tests against private read and private write, should I

Re: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread guilhermebla...@gmail.com
[mailto:pierre@gmail.com] Sent: Sunday, December 11, 2011 6:47 PM To: Clint M Priest Cc: internals@lists.php.net Subject: Re: [PHP-DEV] Accessors v2 Patch oh right, I missed them. Yes, so it is covered as well :) On Mon, Dec 12, 2011 at 1:42 AM, Clint M Priest cpri...@zerocue.com wrote

Re: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread Will Fitch
() Comments? -Original Message- From: Pierre Joye [mailto:pierre@gmail.com] Sent: Sunday, December 11, 2011 6:47 PM To: Clint M Priest Cc: internals@lists.php.net Subject: Re: [PHP-DEV] Accessors v2 Patch oh right, I missed them. Yes, so it is covered as well :) On Mon, Dec 12

Re: [PHP-DEV] Accessors v2 Patch

2011-12-11 Thread guilhermebla...@gmail.com
] Sent: Sunday, December 11, 2011 6:47 PM To: Clint M Priest Cc: internals@lists.php.net Subject: Re: [PHP-DEV] Accessors v2 Patch oh right, I missed them. Yes, so it is covered as well :) On Mon, Dec 12, 2011 at 1:42 AM, Clint M Priest cpri...@zerocue.com wrote: There are already two tests