RE: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/TSRM/tsrm_win32.c trunk/TSRM/tsrm_win32.c

2009-08-20 Thread Andi Gutmans
- > From: Garrett Serack [mailto:garre...@microsoft.com] > Sent: Thursday, August 20, 2009 7:24 AM > To: Stas Malyshev; Pierre > Cc: 'PHP Internals' > Subject: RE: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS > branches/PHP_5_3/TSRM/tsrm_win32.c trunk/T

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/TSRM/tsrm_win32.c trunk/TSRM/tsrm_win32.c

2009-08-20 Thread Pierre Joye
it is reverted already. On Thu, Aug 20, 2009 at 4:24 PM, Garrett Serack wrote: > Dammit. > > I am indeed wrong in this. I was pretty sure that popen on Unix > *didn't* go via 'sh', but after digging deeper, you are completely > correct. > > We should revert that patch, and I'll write a new separat

RE: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/TSRM/tsrm_win32.c trunk/TSRM/tsrm_win32.c

2009-08-20 Thread Garrett Serack
Dammit. I am indeed wrong in this. I was pretty sure that popen on Unix *didn't* go via 'sh', but after digging deeper, you are completely correct. We should revert that patch, and I'll write a new separate routine that doesn't use cmd.exe as a gateway. My Apologies. G -Original Message---

Re: [PHP-DEV] Re: [PHP-CVS] svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/TSRM/tsrm_win32.c trunk/TSRM/tsrm_win32.c

2009-08-20 Thread Richard Quadling
2009/8/19 Stanislav Malyshev : > Hi! > >> Initially, this prevents popen_ex from failing when the actual >> executable doesn't exist, since "cmd.exe /c c:\foo\bar\xxx.exe" will >> *always* successfully start a process. This can be seen in bug >> #43327. >> >> Second, is that by having the intermedi