RE: [PHP-DEV] Re: Patch: getters/setters syntax Implementation

2011-12-06 Thread Christian Kaps
Hi, I also find this syntax confusing and I think it has a huge WTF factor. Some thoughts about the syntax: - At the first glance, it isn't clear which visibility the getter or setter has - The extra indentation level makes the code more unreadable class Foo { /** * */

Re: [PHP-DEV] Re: Patch: getters/setters syntax Implementation

2011-12-06 Thread Pierre Joye
On Tue, Dec 6, 2011 at 4:23 AM, Clint M Priest cpri...@zerocue.com wrote: I believe the attempt with the RFC was to mimic the syntax that C# went with, the RFC is here: https://wiki.php.net/rfc/propertygetsetsyntax C# like setter/getter is definitely what I would like to have in PHP, it is a

Re: [PHP-DEV] Re: Patch: getters/setters syntax Implementation

2011-12-06 Thread Rasmus Schultz
On Tue, Dec 6, 2011 at 3:45 AM, Christian Kaps christian.k...@mohiva.comwrote: Hi, I also find this syntax confusing and I think it has a huge WTF factor. Some thoughts about the syntax: - At the first glance, it isn't clear which visibility the getter or setter has - The extra

RE: [PHP-DEV] Re: Patch: getters/setters syntax Implementation

2011-12-06 Thread Clint M Priest
@lists.php.net Subject: Re: [PHP-DEV] Re: Patch: getters/setters syntax Implementation On Tue, Dec 6, 2011 at 4:23 AM, Clint M Priest cpri...@zerocue.com wrote: I believe the attempt with the RFC was to mimic the syntax that C# went with, the RFC is here: https://wiki.php.net/rfc

Re: [PHP-DEV] Re: Patch: getters/setters syntax Implementation

2011-12-06 Thread Stas Malyshev
Hi! I believe the attempt with the RFC was to mimic the syntax that C# went with, the RFC is here: https://wiki.php.net/rfc/propertygetsetsyntax Reading this RFC I notice it makes get/set keywords. This would lead to huge amount of breakage in existing code, so I strongly suggest to look for

RE: [PHP-DEV] Re: Patch: getters/setters syntax Implementation

2011-12-05 Thread Clint M Priest
I believe the attempt with the RFC was to mimic the syntax that C# went with, the RFC is here: https://wiki.php.net/rfc/propertygetsetsyntax The first public would apply to either of the get/set which did not have it further defined, for example: public $Hours { get { ... }