Re: [PHP-DEV] LDAP controls in response

2005-11-14 Thread Jani Taskinen
On Mon, 14 Nov 2005, Pierangelo Masarati wrote: sorry to bother you again. Do you think there are chances to see controls in LDAP results in PHP 5/HEAD any soon? Another thing we'd need is LDAP I'll look into it but this won't get into 5.1.0. We're gonna release 5.1.1 quite soon afte

Re: [PHP-DEV] LDAP controls in response

2005-11-14 Thread Pierangelo Masarati
On Wed, 2005-11-09 at 10:03 +0200, Jani Taskinen wrote: > Anyway, it might be the time to cleanup the API of this extension and make it simpler. It's pretty confusing as it is. > The returned arrays are also weird with their "count" fields and > such. Jani, sorry to bother you again. D

Re: [PHP-DEV] LDAP controls in response

2005-11-10 Thread Pierangelo Masarati
On Wed, 2005-11-09 at 10:03 +0200, Jani Taskinen wrote: > Anyway, it might be the time to cleanup the API of this extension > and make it simpler. It's pretty confusing as it is. > The returned arrays are also weird with their "count" fields and such. OK, Jani. I've removed those "

Re: [PHP-DEV] LDAP controls in response

2005-11-09 Thread Pierangelo Masarati
> On Wed, 9 Nov 2005, Pierangelo Masarati wrote: > >> >> On Wed, 2005-11-09 at 07:05 +0200, Jani Taskinen wrote: >>> The "control-patch" looks okay. But the "warning-fix-patch" really >>> doesn't. >>> You're actually changing some functions behaviour with some of >>> those >>> chang

Re: [PHP-DEV] LDAP controls in response

2005-11-09 Thread Jani Taskinen
On Wed, 9 Nov 2005, Pierangelo Masarati wrote: On Wed, 2005-11-09 at 07:05 +0200, Jani Taskinen wrote: The "control-patch" looks okay. But the "warning-fix-patch" really doesn't. You're actually changing some functions behaviour with some of those changes. Maybe you didn't notic

Re: [PHP-DEV] LDAP controls in response

2005-11-08 Thread Pierangelo Masarati
On Wed, 2005-11-09 at 07:05 +0200, Jani Taskinen wrote: > The "control-patch" looks okay. But the "warning-fix-patch" really > doesn't. > You're actually changing some functions behaviour with some of those > changes. Maybe you didn't notice but there's ldap_get_values() and >

Re: [PHP-DEV] LDAP controls in response

2005-11-08 Thread Jani Taskinen
The "control-patch" looks okay. But the "warning-fix-patch" really doesn't. You're actually changing some functions behaviour with some of those changes. Maybe you didn't notice but there's ldap_get_values() and ldap_get_values_len() separately. And there's ldap_bind() and ldap_s

Re: [PHP-DEV] LDAP controls in response

2005-11-08 Thread Pierangelo Masarati
On Wed, 2005-11-09 at 00:37 +0200, Jani Taskinen wrote: > I quickly glanced through your patch and if you don't mind, > can you please separate the warning-fixes and functionality patch? > (one patch for fixes, one for adding new stuff :) > > It's a bit too much to try and see

Re: [PHP-DEV] LDAP controls in response

2005-11-08 Thread Jani Taskinen
I quickly glanced through your patch and if you don't mind, can you please separate the warning-fixes and functionality patch? (one patch for fixes, one for adding new stuff :) It's a bit too much to try and see what was added and what is supposed to silence some warning.