Re: [PHP-DEV] PDO\Sqlite: Add transaction mode attribute

Hi, Is there anything I could do here to get this reviewed before the 8.5 release? As mentioned earlier the proposed implementation should not be subject to the feature freeze. Thank you. Samuel On August 12, 2025, "Samuel Štancl" wrote: > By enums

Re: [PHP-DEV] PDO\Sqlite: Add transaction mode attribute

Hi Matteo, >From reading earlier discussions my understanding is the feature freeze only applies to things that need RFCs. With PRs that add simple constants not necessarily needing an RFC. Personally I think the diff in the linked PR itself matches that description well, while the alternative im

Re: [PHP-DEV] PDO\Sqlite: Add transaction mode attribute

Hi Samuel, Il 04/09/2025 00:38, Samuel Štancl ha scritto: Hi, Is there anything I could do here to get this reviewed before the 8.5 release? As mentioned earlier the proposed implementation should not be subject to the feature freeze. https://github.com/php/php-src/pull/19317

Re: [PHP-DEV] PDO\Sqlite: Add transaction mode attribute

On 4 September 2025 09:40:46 BST, "Samuel Štancl" wrote: >Hi Matteo, > >>From reading earlier discussions my understanding is the feature freeze >only applies to things that need RFCs. With PRs that add simple >constants not necessarily needing an RFC. > >Personally I think the diff in the linked

Re: [PHP-DEV] PDO\Sqlite: Add transaction mode attribute

By enums I'm assuming you mean PHP enums. That could work and would solve my issue of trying to represent the values of the attribute (only thing I'm not sure about is Pdo\SqliteTransactionMode being directly in the Pdo namespace). I've included a sample implementation in this comment

Re: [PHP-DEV] PDO\Sqlite: Add transaction mode attribute

On 2025-08-12 07:35, Samuel Štancl wrote: Hi, I've opened a PR adding a new attribute to PDO\Sqlite: https:// github.com/php/php-src/pull/19317 As far as th