Re: [PHP-DEV] PHP_SESSION_* constant values

2012-01-28 Thread Sanford Whiteman
> There is no BC change here as session_status() has been added in the > 5_4 branch as far as i can tell. OK, fair enough, I didn't understand it was trying to get into 5.4. -- S. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] PHP_SESSION_* constant values

2012-01-28 Thread Paul Dragoonis
On Sat, Jan 28, 2012 at 9:14 PM, Sanford Whiteman wrote: >> I believe comparing the value against a constant, is always more >> readable than wondering what "truthy" means. if(session_status() === >> PHP_SESSION_ACTIVE) is much self-documenting than the proposed change. > > ...  also  an  obvious

Re: [PHP-DEV] PHP_SESSION_* constant values

2012-01-28 Thread Sanford Whiteman
> I believe comparing the value against a constant, is always more > readable than wondering what "truthy" means. if(session_status() === > PHP_SESSION_ACTIVE) is much self-documenting than the proposed change. ... also an obvious BC break for anyone who was using the values instead of the

Re: [PHP-DEV] PHP_SESSION_* constant values

2012-01-28 Thread Stas Malyshev
Hi! I'd like to suggest we change these values to - PHP_SESSION_DISABLED = -1 - PHP_SESSION_NONE = 0 - PHP_SESSION_ACTIVE = 1 This way, one can do if(session_status()) to check if there is an active session, rather than having to compare the result to a constant. Any objections?

Re: [PHP-DEV] PHP_SESSION_* constant values

2012-01-28 Thread Paul Dragoonis
On Sat, Jan 28, 2012 at 7:17 PM, Justin Martin wrote: > Hello everyone, > > For the result of session_status(), the corresponding constants for the > sessions state are > >  - PHP_SESSION_DISABLED = 0 >  - PHP_SESSION_NONE = 1 >  - PHP_SESSION_ACTIVE = 2 > > I'd like to suggest we change these val