Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard md5.c sha1.c

2005-04-15 Thread Andrey Hristov
Uwe Schindler wrote: We can left that out. The flag to search in the include path is available to all file_* functions in PHP. Make it sense to search in the include path for example in the exif-functions? But this parameter is available there, too. So for consistency I added this parameter.

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard md5.c sha1.c

2005-04-15 Thread Uwe Schindler
I can remove this parameter. Without it, the function declaration keeps constant and we could add this patch to PHP_5_0, too. It does not change the user interface but makes C code simplier and adds support for URLs without any cost to it. The original intention to change the md5/sha1 code was

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard md5.c sha1.c

2005-04-15 Thread Derick Rethans
On Fri, 15 Apr 2005, Uwe Schindler wrote: I can remove this parameter. Without it, the function declaration keeps constant and we could add this patch to PHP_5_0, too. It does not change the user interface but makes C code simplier and adds support for URLs without any cost to it. I think

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard md5.c sha1.c

2005-04-15 Thread Derick Rethans
On Fri, 15 Apr 2005, Andrey Hristov wrote: Uwe Schindler wrote: We can left that out. The flag to search in the include path is available to all file_* functions in PHP. Make it sense to search in the include path for example in the exif-functions? But this parameter is available there,

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard md5.c sha1.c

2005-04-15 Thread Sara Golemon
We can left that out. The flag to search in the include path is available to all file_* functions in PHP. Make it sense to search in the include path for example in the exif-functions? But this parameter is available there, too. So for consistency I added this parameter. Except that

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard md5.c sha1.c

2005-04-15 Thread Uwe Schindler
At 18:51 15.04.2005, Sara Golemon wrote: Rather than getting prototype change happy. How about a context parameter for the file:// wrapper since it only applies to plainfiles anyway. (Note: Okay so it applies to plainfile wrappers like compress.gzip:// but that just opens the subordinate

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard md5.c sha1.c

2005-04-15 Thread Ilia Alshanetsky
Parameter removed again. Any complaints to add this patch (lowlevel file io to streams in sha1_file md5_file) to PHP_5_0 (PHP_4_3 ???), too? I have no objections to MFHing the path to 4.3. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: