As a side note, I think the following code could be optimized:
Probably it could, but note that the code not just moves the stack
pointer, but also destroys arguments there (zval_ptr_dtor).
+ while (zend_vm_stack_top(TSRMLS_C) != stack_frame) {
+ zval *stack_zval_p = zend_vm_stack_pop(TSRMLS
Hi Nuno,
Thank you for your notes.
Nuno Lopes wrote:
Hi Dmitry,
The patch looks fine. Although it wastes a bit more memory than the
current implementation, I think it's ok.
I think the patch uses exactly the same amount of memory, except that
the current implementation uses CPU stack and t
Hi Dmitry,
The patch looks fine. Although it wastes a bit more memory than the current
implementation, I think it's ok. It also has some memory fragmentation,
which shouldn't be an issue (we don't have functions with 100 arguments :P).
As a side note, I think the following code could be optim
