Re: [PHP-DEV] Unintuitive array_combine() behaviour

2010-08-26 Thread Adam Harvey
On 27 August 2010 01:07, Joel Perras wrote: > If someone with the appropriate karma could review this and commit it > to trunk, that would be grand. Thanks heaps for the patch, Joel. Looked good to me, and IMO the changed behaviour does make more sense, so I've committed it to trunk. Thanks agai

Re: [PHP-DEV] Unintuitive array_combine() behaviour

2010-08-26 Thread Joel Perras
Since there didn't seem to be anyone who disagreed on the odd behaviour of array_combine() with empty arrays as arguments, I've written up a patch for this and attached it to the existing feature change/request report: Report: http://bugs.php.net/bug.php?id=34857 Patch: http://paste.roguecoders.co

Re: [PHP-DEV] Unintuitive array_combine() behaviour

2010-07-16 Thread Richard Quadling
On 16 July 2010 02:42, Joel Perras wrote: > array_combine(array(), array()) triggers an E_WARNING and returns > false, instead of simply returning an empty array with no triggered > warning. > > This is not a bug, but was intentionally written as such - see > ext/standard/array.c around lines 4480