Re: [PHP-DEV] WIKI: phpng-upgrading

2016-01-21 Thread Nikita Popov
On Wed, Jan 20, 2016 at 11:07 PM, Sean DuBois wrote: > Hi! > > I tried to get access to that page as well, but didn't have any luck > would you mind adding the zend_parse_paramaters changes? > > 'l' went from 'long' -> 'zend_long' and 's' went from 'int' -> 'size_t'. > > So many extensions have b

Re: [PHP-DEV] WIKI: phpng-upgrading

2016-01-20 Thread François Laupretre
Le 20/01/2016 23:07, Sean DuBois a écrit : On Thu, Jan 21, 2016 at 06:55:41AM +0900, Yasuo Ohgaki wrote: Hi ZendEngine developers, I'm not sure if the wiki page is maintained, but I noticed few errors. https://wiki.php.net/phpng-upgrading#strings has following example. - ZVAL_STRING(zv, str,

Re: [PHP-DEV] WIKI: phpng-upgrading

2016-01-20 Thread Yasuo Ohgaki
Hi Nikita, On Thu, Jan 21, 2016 at 7:28 AM, Nikita Popov wrote: > These examples are correct. In PHP 7 ZVAL_STRING always duplicates, which is > what the 1 parameter used to signify. Oh, now I see the example intention. Thank you. -- Yasuo Ohgaki yohg...@ohgaki.net -- PHP Internals - PHP Runt

Re: [PHP-DEV] WIKI: phpng-upgrading

2016-01-20 Thread Nikita Popov
On Wed, Jan 20, 2016 at 10:55 PM, Yasuo Ohgaki wrote: > Hi ZendEngine developers, > > I'm not sure if the wiki page is maintained, but I noticed few errors. > > https://wiki.php.net/phpng-upgrading#strings > has following example. > > - ZVAL_STRING(zv, str, 1); > + ZVAL_STRING(zv, str); > > - ZVA

Re: [PHP-DEV] WIKI: phpng-upgrading

2016-01-20 Thread Yasuo Ohgaki
Hi Sean, On Thu, Jan 21, 2016 at 7:07 AM, Sean DuBois wrote: > > I tried to get access to that page as well, but didn't have any luck > would you mind adding the zend_parse_paramaters changes? > > 'l' went from 'long' -> 'zend_long' and 's' went from 'int' -> 'size_t'. > > So many extensions have

Re: [PHP-DEV] WIKI: phpng-upgrading

2016-01-20 Thread Sean DuBois
On Thu, Jan 21, 2016 at 06:55:41AM +0900, Yasuo Ohgaki wrote: > Hi ZendEngine developers, > > I'm not sure if the wiki page is maintained, but I noticed few errors. > > https://wiki.php.net/phpng-upgrading#strings > has following example. > > - ZVAL_STRING(zv, str, 1); > + ZVAL_STRING(zv, str); > >