Re: [PHP-DEV] add php.ini entry to set default user_agent for curl

2021-04-12 Thread Michael Maroszek
Hi Nikita, sure! We are embedding PHP through SAPI to allow our users interaction through PHP scripts. That allows them to automate a lot of things and one of them is doing web requests. For our new version we wanted to set the user-agent, to properly recognize/categorize requests on our infrastru

Re: [PHP-DEV] add php.ini entry to set default user_agent for curl

2021-04-12 Thread Nikita Popov
On Thu, Apr 8, 2021 at 2:41 PM Michael Maroszek wrote: > Dear Internals, > I'd like to suggest a new enhancement for 8.1 as outlined in the title. > > The initial pull request is here: > https://github.com/php/php-src/pull/6834/files > > --- Details: > Since quite a while PHP offers a dedicated u

Re: [PHP-DEV] add php.ini entry to set default user_agent for curl

2021-04-08 Thread Ayesh Karunaratne
Hi Michael, Thanks for opening this conversation and the PR. Most HTTP client libraries that need to set a custom user agent do so with `curl_setopt` because it needs to contain a library version or some sort of dynamic values. They will likely not benefit from this change. On the other hand, libr