Re: [PHP-DEV] pspell tweak.

2008-08-13 Thread Nuno Lopes
C++ is a superset of C thus any C code can be complied as C++ as long as it doesn't use any C++ reserved words. That is not true at all, although it's a common misconception. Just try the following in C and in C++: printf("sizeof('x') == %d\n", (int)sizeof('x')); (hint: they will give you diff

Re: [PHP-DEV] pspell tweak.

2008-08-13 Thread Phil Oleson
Nuno Lopes wrote: Antony Dovgal wrote: On 13.08.2008 01:31, Phil Oleson wrote: Thus the diff -u I sent in.. which resolves the above compiler failure with g++. Committed, thanks! Btw, how and why did you manage to get g++ compiling plain C code? umm.. how? cd ext/pspell /usr/local/php5/bi

Re: [PHP-DEV] pspell tweak.

2008-08-13 Thread Nuno Lopes
Antony Dovgal wrote: On 13.08.2008 01:31, Phil Oleson wrote: Thus the diff -u I sent in.. which resolves the above compiler failure with g++. Committed, thanks! Btw, how and why did you manage to get g++ compiling plain C code? umm.. how? cd ext/pspell /usr/local/php5/bin/phpize env CC=g++

Re: [PHP-DEV] pspell tweak.

2008-08-13 Thread Phil Oleson
Antony Dovgal wrote: On 13.08.2008 01:31, Phil Oleson wrote: Thus the diff -u I sent in.. which resolves the above compiler failure with g++. Committed, thanks! Btw, how and why did you manage to get g++ compiling plain C code? umm.. how? cd ext/pspell /usr/local/php5/bin/phpize env CC=g

Re: [PHP-DEV] pspell tweak.

2008-08-13 Thread Antony Dovgal
On 13.08.2008 01:31, Phil Oleson wrote: Thus the diff -u I sent in.. which resolves the above compiler failure with g++. Committed, thanks! Btw, how and why did you manage to get g++ compiling plain C code? -- Wbr, Antony Dovgal -- PHP Internals - PHP Runtime Development Mailing List To un

Re: [PHP-DEV] pspell tweak.

2008-08-12 Thread Phil Oleson
Antony Dovgal wrote: On 11.08.2008 21:54, Phil Oleson wrote: Was running pspell through g++ and found that a couple of error conditions segments in pspell.c are using the wrong cleanup methods. delete_pspell_manager() should be delete_pspell_can_have_error() We'd certainly need some more de

Re: [PHP-DEV] pspell tweak.

2008-08-12 Thread Antony Dovgal
On 11.08.2008 21:54, Phil Oleson wrote: Was running pspell through g++ and found that a couple of error conditions segments in pspell.c are using the wrong cleanup methods. delete_pspell_manager() should be delete_pspell_can_have_error() We'd certainly need some more details to get this pat