Re: [PHP-DEV] [v][sf]printf additions (#, E, g, G)

Hi Marcus, - Original Message - From: "Marcus Boerger" Sent: Thursday, July 20, 2006 2:21 PM Subject: Re: [PHP-DEV] [v][sf]printf additions (#, E, g, G) > Hello Matt, > > Thursday, July 20, 2006, 2:20:46 PM, you wrote: > > > Hi, > > > I've wished there was a *printf() float specifier th

[PHP-DEV] RfC: rethink OO inheritance strictness

Hi (Marcus), unfortunately I'm not very happy with the direction OO strictness takes in PHP. I'm sure I'm not alone and many people second this feeling. Precisely, let's have a look at the following: [EMAIL PROTECTED]:~/build/php-5.2-debug$ cli -d"error_reporting=8191" -r 'class c{function f

[PHP-DEV] Re: RfC: rethink OO inheritance strictness

Michael Wallner wrote: Hi (Marcus), unfortunately I'm not very happy with the direction OO strictness takes in PHP. I'm sure I'm not alone and many people second this feeling. Precisely, let's have a look at the following: [EMAIL PROTECTED]:~/build/php-5.2-debug$ cli -d"error_reporting=8191"

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

I agree with this point. The sub class is a valid entity in its own right. The methods (and the parameters) it has are part of that class. If they overwrite a parent class's method, then fine. Instance of either class would have different parameters for the same named method. If the sub class ne

[PHP-DEV] Re: cvs: ZendEngine2(PHP_5_2) / zend_API.c zend_exceptions.c zend_vm_def.h zend_vm_execute.h

Dmitry Stogov wrote: dmitry Fri Jul 21 08:39:32 2006 UTC Modified files: (Branch: PHP_5_2) /ZendEngine2 zend_API.c zend_exceptions.c zend_vm_def.h zend_vm_execute.h Log: Fixed wrong "type" argument to read_property() handler --

Re: [PHP-DEV] Adding pecl/zip to 5.2

Hi Andi, On 7/21/06, Andi Gutmans <[EMAIL PROTECTED]> wrote: Although I don't want to clutter the list further, I do agree with Derick&Marcus on this. I actually like ZipArchive() better :) You agree with Rasmus and Derick, as Marcus does want it in for all possible reasons. However, it seems

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

Richard Quadling wrote: I agree with this point. The sub class is a valid entity in its own right. The methods (and the parameters) it has are part of that class. If they overwrite a parent class's method, then fine. Instance of either class would have different parameters for the same named met

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

Michael Wallner wrote: > [EMAIL PROTECTED]:~/build/php-unicode-debug$ cli > -d"error_reporting=8191" -r 'class c{function f(){}} class d extends > c{function f($a){}}' > Fatal error: Declaration of d::f() must be compatible with that of > c::f() in Command line code on line 1 > > > I *really* thi

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

On Fri, 21 Jul 2006, Lukas Smith wrote: > Richard Quadling wrote: > > I agree with this point. The sub class is a valid entity in its own > > right. The methods (and the parameters) it has are part of that class. > > If they overwrite a parent class's method, then fine. Instance of > > either cla

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

On Fri, 21 Jul 2006, Mike Bretz wrote: > Michael Wallner wrote: > > [EMAIL PROTECTED]:~/build/php-unicode-debug$ cli > > -d"error_reporting=8191" -r 'class c{function f(){}} class d extends > > c{function f($a){}}' > > Fatal error: Declaration of d::f() must be compatible with that of > > c::f() i

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

Derick Rethans wrote: On Fri, 21 Jul 2006, Lukas Smith wrote: Richard Quadling wrote: I agree with this point. The sub class is a valid entity in its own right. The methods (and the parameters) it has are part of that class. If they overwrite a parent class's method, then fine. Instance of ei

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

I see it as catch up to OOP. I've never used Java. I've used Delphi though. I suppose the main issue is that userland sees OOP and expects things to be similar to other OOPs they've used. They're blinkered as to why it ISN'T the same! Like discrete setters/getters providing accesssibilty or being

RE: [PHP-DEV] RfC: rethink OO inheritance strictness

Derick Rethans wrote on Friday, July 21, 2006 11:31 AM: > It's quite a different thing in C++ as there you have method > overloading which PHP doesn't have. Therefore your argument doesn't Exactly the point. It's parameter polymorphism in C++/Java. > hold here as they

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

Shouldn't be necessary. As there are 2 different methods, they should be allowed different parameter signatures. If you want to extend a method but hide original implementation, you can't change the parameter signature. I'm on the opposite side of the fence to you it seems! On 21/07/06, Soenke Ru

RE: [PHP-DEV] RfC: rethink OO inheritance strictness

If a constructor gets overridden, why should it not be the same behaviour with all methods? -Original Message- From: Derick Rethans [mailto:[EMAIL PROTECTED] Sent: 21 July 2006 10:31 To: Mike Bretz Cc: internals@lists.php.net Subject: Re: [PHP-DEV] RfC: rethink OO inheritance strictness

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

Exactly. Consistency. On 21/07/06, Daine Mamacos <[EMAIL PROTECTED]> wrote: If a constructor gets overridden, why should it not be the same behaviour with all methods? -- - Richard Quadling Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731 "Standing on the shoulder

RE: [PHP-DEV] RfC: rethink OO inheritance strictness

Richard Quadling wrote on Friday, July 21, 2006 12:28 PM: > Shouldn't be necessary. As there are 2 different methods, they should > be allowed different parameter signatures. If you want to extend a > method but hide original implementation, you can't change the > parame

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

On Fri, 21 Jul 2006 10:55:05 +0200 [EMAIL PROTECTED] (Michael Wallner) wrote: Hi (Marcus), unfortunately I'm not very happy with the direction OO strictness takes in PHP. I'm sure I'm not alone and many people second this feeling. Precisely, let's have a look at the following: [EMAIL PROTEC

RE: [PHP-DEV] RfC: rethink OO inheritance strictness

> Hi (Marcus), > > unfortunately I'm not very happy with the direction OO > strictness takes > in PHP. I'm sure I'm not alone and many people second this feeling. > > > Precisely, let's have a look at the following: > > [EMAIL PROTECTED]:~/build/php-5.2-debug$ cli > -d"error_reporting=8191"

RE: [PHP-DEV] Adding pecl/zip to 5.2

> Many people (incl. php devs) asked me if I can include zip in 5.2.0. > Ilia thought it was too late in the game and planed to do it in 5.2.1. > > I like to have it in, as experimental. > > Please note that it intoduces a new class called Zip, but I > never saw a > php zip implementation name

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

Isn't that why we have interfaces and abstract functions? (I realize that that would remove the possibility to define a fallback function in the parent class though.) - Ron ""Soenke Ruempler"" <[EMAIL PROTECTED]> schreef in bericht news:[EMAIL PROTECTED] > Richard Quadling

Re: [PHP-DEV] Adding pecl/zip to 5.2

I was thinking the same thing. We can of course clutter the namespace with a class for every possible file extension we want to develop an API for, but maybe we can do the smart thing and do what PDO does for databases: present a unified API. I don't like the idea of having GZip, Zip, Rar, Arj,

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

I agree and understand that InstanceOf will return true if class B is a descendent of the class A. But that doesn't mean that class B is the same as class A. With overloading, the parameter signature is used to determine which method is used. The method has to exist within the class heirarchy.

RE: [PHP-DEV] RfC: rethink OO inheritance strictness

Richard Quadling wrote on Friday, July 21, 2006 1:16 PM: > Ah. I see the difference. I'm expecting overloading. Hmmm. Even with > that though, overloading is the desired effect. But PHP has no parameter overloading, only overloading with interceptor methods. IMHO what y

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

Ah. I see the difference. I'm expecting overloading. Hmmm. Even with that though, overloading is the desired effect. On 21/07/06, Soenke Ruempler <[EMAIL PROTECTED]> wrote: Richard Quadling wrote on Friday, July 21, 2006 12:28 PM: > Shouldn't be necessary. As there ar

Re: [PHP-DEV] Adding pecl/zip to 5.2

Hello, On 7/21/06, Ron Korving <[EMAIL PROTECTED]> wrote: I was thinking the same thing. We can of course clutter the namespace with a class for every possible file extension we want to develop an API for, but maybe we can do the smart thing and do what PDO does for databases: present a unified

[PHP-DEV] CVS Account Request: cyberowl

Korean Document Translation. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

Good points. I think I'll leave Michael to answer that. He wants it changed. I'm just saying that overloading would be a valid solution. On 21/07/06, Soenke Ruempler <[EMAIL PROTECTED]> wrote: Richard Quadling wrote on Friday, July 21, 2006 1:16 PM: > Ah. I see the di

Re: [PHP-DEV] Adding pecl/zip to 5.2

A compression wrapper like PDO would be great. And they do all do the same things more or less. Take data and compress it. Take compressed data and uncompress it. Not that different. On 21/07/06, Pierre <[EMAIL PROTECTED]> wrote: Hello, On 7/21/06, Ron Korving <[EMAIL PROTECTED]> wrote: > I was

Re: [PHP-DEV] Adding pecl/zip to 5.2

Well, if they all implement some common interface, that would really be an improvement too. And I guess in that case there'd be GZipArchive, ZipArchive, RarArchive, ... classes. People have a choice then; use the specific format of their choice and have all the extras it comes with, or go for a

[PHP-DEV] [PATCH] array_combine is not binary-key safe

Hi, I don't know if array_combine() was intentionally made binary-key unsafe, but it seems wrong and inconsistent since binary keys work everywhere else I can think of -- including array_flip() and the new array_fill_keys(). And updating it is a bit of an optimization by eliminating strlen() call

Re: [PHP-DEV] Adding pecl/zip to 5.2

So where does this leave adding pecl/zip to 5.2? PDO is not core for Windows so should zip? On 21/07/06, Pierre <[EMAIL PROTECTED]> wrote: On 7/21/06, Richard Quadling <[EMAIL PROTECTED]> wrote: > A compression wrapper like PDO would be great. And they do all do the > same things more or less. T

Re: [PHP-DEV] Adding pecl/zip to 5.2

Richard Quadling wrote: > So where does this leave adding pecl/zip to 5.2? PDO is not core for > Windows so should zip? PDO is bundled in the core PHP distribution. Pierre was not asking for Zip to be enabled by default, just to be a part of the distro. Edin -- PHP Internals - PHP Runtime Devel

Re: [PHP-DEV] [PATCH] array_combine is not binary-key safe

Hi, There are 46 uses of add_assoc_zval() in the CVS. Many are with fixed length strings for the key. Should the others all be using add_assoc_zval_ex() ? On 21/07/06, Matt W <[EMAIL PROTECTED]> wrote: Hi, I don't know if array_combine() was intentionally made binary-key unsafe, but it seems

Re: [PHP-DEV] Adding pecl/zip to 5.2

Edin Kadribasic wrote: Richard Quadling wrote: So where does this leave adding pecl/zip to 5.2? PDO is not core for Windows so should zip? PDO is bundled in the core PHP distribution. Pierre was not asking for Zip to be enabled by default, just to be a part of the distro. Yes, exactly. As f

Re: [PHP-DEV] Adding pecl/zip to 5.2

On 7/21/06, Ron Korving <[EMAIL PROTECTED]> wrote: Well, if they all implement some common interface, that would really be an improvement too. And I guess in that case there'd be GZipArchive, ZipArchive, RarArchive, ... classes. People have a choice then; use the specific format of their choice

Re: [PHP-DEV] Adding pecl/zip to 5.2

On 7/21/06, Richard Quadling <[EMAIL PROTECTED]> wrote: A compression wrapper like PDO would be great. And they do all do the same things more or less. Take data and compress it. Take compressed data and uncompress it. Not that different. Then do it in PHP, it is very easy to create one for the

Re: [PHP-DEV] [PATCH] array_combine is not binary-key safe

Hi Richard, I think I've seen those instances that you're referring to. By fixed length string I assume you mean hard-coded "string_key". Yeah, I would think those should use add_assoc_*_ex() since the length is known (sizeof("string_key") etc.) to save unnecessary strlen() calls. Unless compil

Re: [PHP-DEV] Adding pecl/zip to 5.2

On 7/21/06, Richard Quadling <[EMAIL PROTECTED]> wrote: So where does this leave adding pecl/zip to 5.2? PDO is not core for Windows so should zip? PDO is not core on windows? I do not understand what you say here. --Pierre -- PHP Internals - PHP Runtime Development Mailing List To unsubscrib

Re: [PHP-DEV] Adding pecl/zip to 5.2

I'm corrected by Edin. Misunderstood. So, why are some extensions bundled and not others? Surely all successfully built, non experimental extensions should be part of the distro? On 21/07/06, Pierre <[EMAIL PROTECTED]> wrote: On 7/21/06, Richard Quadling <[EMAIL PROTECTED]> wrote: > So where

RE: [PHP-DEV] RfC: rethink OO inheritance strictness

On Fri, 21 Jul 2006, Soenke Ruempler wrote: > Derick Rethans wrote on Friday, July 21, 2006 > 11:31 AM: > > > It's quite a different thing in C++ as there you have method > > overloading which PHP doesn't have. Therefore your argument doesn't > > Exactly the point. It'

[PHP-DEV] Re: RfC: rethink OO inheritance strictness

Hi all, I wasn't talking about programming paradigms and correctly following them, but about PHPs freedom it was so generously giving to me in the past. A fatal error doesn't give me any freedom, no matter if it's totally correct or not. -- Michael -- PHP Internals - PHP Runtime Development Ma

[PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2(PHP_5_2) / zend_object_handlers.c /tests bug32660.phpt bug37667.phpt

On Fri, 21 Jul 2006, Dmitry Stogov wrote: > dmitryFri Jul 21 10:32:17 2006 UTC > > Modified files: (Branch: PHP_5_2) > /ZendEngine2 zend_object_handlers.c > /ZendEngine2/testsbug32660.phpt bug37667.phpt > Log: > Changed error message (E_ER

Re: [PHP-DEV] Adding pecl/zip to 5.2

Hello Pierre, Friday, July 21, 2006, 11:16:22 AM, you wrote: > Hi Andi, > On 7/21/06, Andi Gutmans <[EMAIL PROTECTED]> wrote: >> Although I don't want to clutter the list further, I do agree with >> Derick&Marcus on this. I actually like ZipArchive() better :) > You agree with Rasmus and Derick

Re: [PHP-DEV] [v][sf]printf additions (#, E, g, G)

Hello Matt, sounds good then, keep going. best regards marcus Friday, July 21, 2006, 10:08:19 AM, you wrote: > Hi Marcus, > - Original Message - > From: "Marcus Boerger" > Sent: Thursday, July 20, 2006 2:21 PM > Subject: Re: [PHP-DEV] [v][sf]printf additions (#, E, g, G) >> Hello

Re: [PHP-DEV] Adding pecl/zip to 5.2

Hi, On 7/21/06, Marcus Boerger <[EMAIL PROTECTED]> wrote: I said i am fine, i don't want it. I just cannot accept the classname 'Zip'. que? let do it with -1/0/+1 ;-) --Pierre -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

Hello Michael, first of all the decision never was my decision, second i am not going to let peole run into problem hell. I coded enough PHP 4 OO to see that it didn't make any sense and caused a lot of errors in the code we wrote back then. But once again it is not my decision, i was not even m

Re: [PHP-DEV] Adding pecl/zip to 5.2

Hello Pierre, move to core -0 (as long as EXPERIMENTAL is being removed) ZipArchieve +1 ZipFile +0 Zip -0 regards marcus Friday, July 21, 2006, 7:17:38 PM, you wrote: > Hi, > On 7/21/06, Marcus Boerger <[EMAIL PROTECTED]> wrote: >> I said i am fine, i don't want it. I j

Re: [PHP-DEV] Adding pecl/zip to 5.2

Hello, On 7/21/06, Marcus Boerger <[EMAIL PROTECTED]> wrote: Hello Pierre, move to core -0 (as long as EXPERIMENTAL is being removed) You want it only if it is not experimental, you don't care or you don't want it? (-0 has no sense, btw) ZipArchieve +1 Let say you mean ZipAchirve, ok

Re: [PHP-DEV] Adding pecl/zip to 5.2

Hello Pierre, Friday, July 21, 2006, 7:42:15 PM, you wrote: > Hello, > On 7/21/06, Marcus Boerger <[EMAIL PROTECTED]> wrote: >> Hello Pierre, >> >> move to core -0 (as long as EXPERIMENTAL is being removed) > You want it only if it is not experimental, you don't care or you > don't want it? (

Re: [PHP-DEV] Adding pecl/zip to 5.2

Hi, On 7/21/06, Marcus Boerger <[EMAIL PROTECTED]> wrote: I am -1 moving it to core if the EXPERIMENTAL tag file is present. So I will count your vote as -1. I'm not going to freeze the APIs now. Before 5.2.0 stable, the API will certainly be frozen, but I cannot promise anything. But I got so

Re: [PHP-DEV] Adding pecl/zip to 5.2

On Fri, 21 Jul 2006, Pierre wrote: > Hi, > > On 7/21/06, Marcus Boerger <[EMAIL PROTECTED]> wrote: > > I am -1 moving it to core if the EXPERIMENTAL tag file is present. > > So I will count your vote as -1. I'm not going to freeze the APIs now. Heh? It isn't stable yet? Then why are you even su

Re: [PHP-DEV] Adding pecl/zip to 5.2

Hi, if my vote counts, then: move to core: +1 Zip: +1 ZipArchive: -1 ZipFile: -1 Not sure about other php-developers, but as for me - Zip means ZIP archive, not post code or a fastener. On 7/21/06, Pierre <[EMAIL PROTECTED]> wrote: Hi, On 7/21/06, Marcus Boerger <[EMAIL PROTECTED]> wrote: >

Re: [PHP-DEV] Adding pecl/zip to 5.2

On Fri, 21 Jul 2006 20:09:50 +0200 (CEST) [EMAIL PROTECTED] (Derick Rethans) wrote: > On Fri, 21 Jul 2006, Pierre wrote: > > > Hi, > > > > On 7/21/06, Marcus Boerger <[EMAIL PROTECTED]> wrote: > > > I am -1 moving it to core if the EXPERIMENTAL tag file is present. > > > > So I will count your

Re: [PHP-DEV] Adding pecl/zip to 5.2

No, your vote does NOT count. --Jani On Fri, 21 Jul 2006, Alexander Pak wrote: Hi, if my vote counts, then: move to core: +1 Zip: +1 ZipArchive: -1 ZipFile: -1 Not sure about other php-developers, but as for me - Zip means ZIP archive, not post code or a fastener. On 7/21/06, Pierre

RE: [PHP-DEV] Adding pecl/zip to 5.2

I personally don't think it's *that* useful to have an abstraction on top of archives and in any case, it doesn't make sense for this request to come up now. If you'd like something like that, then I suggest to apply for a PECL account and work on an extension that implments it. As to having ZipAr

RE: [PHP-DEV] RfC: rethink OO inheritance strictness

There's a big difference. Inherited classes should adhere to the instanceof operator. Meaning that if you get an object you can check if it's an instance of another class and if so, you can call it *exactly* the way you could the parent class. This allows for good polymorphic design in applications

[PHP-DEV] Re: E_STRICT

Lukas Smith wrote: Lukas Smith wrote: Ok I see 2 options: 1) Obviously one solution would be to disallow making anything an E_STRICT notice that is not available since the first release of the given major version. Pierre and Anthony seem to favor this solution. So it sounds like Derick is

Re: [PHP-DEV] Adding pecl/zip to 5.2

On 7/21/06, Jani Taskinen <[EMAIL PROTECTED]> wrote: No, your vote does NOT count. His vote counts. He is a php.net member (Summer of Code). THANKS for your understandings, --Pierre -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub

Re: [PHP-DEV] Adding pecl/zip to 5.2

Pierre, The onus is you to convince people that moving a non-stable version of pecl/zip into core is advantageous. So, yes, even if you posted your answers before you might need to repeat yourself. Also, I would suggest that you stop acting like a victim. It's not going to help things.

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

Andi Gutmans wrote: There's a big difference. Inherited classes should adhere to the instanceof operator. Meaning that if you get an object you can check if it's an instance of another class and if so, you can call it *exactly* the way you could the parent class. This allows for good polymorphic

Re: [PHP-DEV] Adding pecl/zip to 5.2

Andrei Zmievski wrote: FWIW, I'm fine with moving it into core if EXPERIMENTAL is removed and it's renamed to ZipArchive. Is that a new (double) standard? It used to be common practice to add new extensions as EXPERIMENTAL to core. IIRC all the last PECL extensions that got moved to core wer

Re: [PHP-DEV] [PATCH] array_combine is not binary-key safe

Yeah, that's probably a good idea. You can submit a patch if you want. :) -Andrei On Jul 21, 2006, at 6:04 AM, Matt W wrote: Hi Richard, I think I've seen those instances that you're referring to. By fixed length string I assume you mean hard-coded "string_key". Yeah, I would think t

Re: [PHP-DEV] RfC: rethink OO inheritance strictness

On Fri, 2006-07-21 at 17:46, Michael Wallner wrote: > Andi Gutmans wrote: > > There's a big difference. Inherited classes should adhere to the > > instanceof operator. Meaning that if you get an object you can check > > if it's an instance of another class and if so, you can call it > > *exactly* t

Re: [PHP-DEV] unicode and xml extensions

Great! I'll put a slide about this into my talk for OSCON. What're your plans for the rest of the XML extensions? -Andrei On Jul 20, 2006, at 6:15 PM, Rob Richards wrote: Andrei Zmievski wrote: Hey Rob, Looks good. Have you tested the filesystem (filename) related functions with non-ASCI

Re: [PHP-DEV] Adding pecl/zip to 5.2

On Fri, 21 Jul 2006, Pierre wrote: On 7/21/06, Jani Taskinen <[EMAIL PROTECTED]> wrote: No, your vote does NOT count. His vote counts. He is a php.net member (Summer of Code). Since when does every @php.net badge earn a right to vote? In my eyes only core devs have that right.

Re: [PHP-DEV] unicode and xml extensions

Almost done with DOM (3 more files to go), so hopefully by Monday. This one will need a lot of testing though. Rob Andrei Zmievski wrote: Great! I'll put a slide about this into my talk for OSCON. What're your plans for the rest of the XML extensions? -Andrei -- PHP Internals - PHP Runtim

Re: [PHP-DEV] unicode and xml extensions

Awesome. I am planning to add "s(encoding)" support to parameter parsing, by the way, so getting strings in UTF-8 encoding will be a bit easier. Would probably need to change the relevant portions of your commits. -Andrei On Jul 21, 2006, at 5:45 PM, Rob Richards wrote: Almost done with

RE: [PHP-DEV] Re: Long awaited line directive

Can you please send me the latest patch for review? I can't find it for some reason. Thx. Andi > -Original Message- > From: Marcus Boerger [mailto:[EMAIL PROTECTED] > Sent: Monday, July 17, 2006 2:34 PM > To: Sara Golemon > Cc: Jeff Moore; internals@lists.php.net > Subject: Re: [PHP-DEV